Tk Library Source Code

View Ticket
Login
Ticket UUID: 466746
Title: socket readable, gets<0 => Error conn.
Type: Bug Version: None
Submitter: nobody Created on: 2001-10-01 07:43:44
Subsystem: ftp Assigned To: andreas_kupries
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2001-10-23 10:45:21
Resolution: Fixed Closed By: andreas_kupries
    Closed on: 2001-10-23 03:45:21
Description:
I have a problem with tcllib-1.0 ftp when working
with a proxy ftp server with the message "ERROR: Error
connecting!"

The problem is due to the fact that in some case,
the ftp socket is readable, but gets proc returns -1.

excerpt from ftp.tcl:
...
    fconfigure $ftp(CtrlSock) -buffering line -blocking
$block -translation {auto crlf}
    fileevent $ftp(CtrlSock) readable [list [namespace
current]::StateHandler $s $ftp(CtrlSock)]
...
proc ftp::StateHandler {s {sock ""}} {
...
        set number [gets $sock bufline]
...
        if { $number > 0 } {
...
        } elseif { [eof $ftp(CtrlSock)] } {
...
        }

# the workaround is to replace this last line with
        } else {
          # in some case, gets gets nothing
          return
        }
User Comments: andreas_kupries added on 2001-10-23 10:45:21:
Logged In: YES 
user_id=75003

Patch committed to head.

andreas_kupries added on 2001-10-21 08:42:07:

File Added - 12276: 466746_ftp.diff

Logged In: YES 
user_id=75003

The fix is correct. Enclosed a patch containing the official
change.

Attachments: