Tk Library Source Code

View Ticket
Login
Ticket UUID: 459197
Title: More fixes in ftpd for the export of the public API
Type: Bug Version: None
Submitter: hemanglavana Created on: 2001-09-06 15:04:08
Subsystem: ftpd Assigned To: andreas_kupries
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2001-09-08 05:22:31
Resolution: Fixed Closed By: andreas_kupries
    Closed on: 2001-09-07 22:22:31
Description:
On further examination wrt [456255], I found out that the 
ftpd.tcl file had few more "namespace export *" stmts in it
which I had missed earlier. Here's a patch for the same.

godel:47> cvs diff ftpd.tcl 
Index: ftpd.tcl
===================================================================
RCS file: /cvsroot/tcllib/tcllib/modules/ftpd/ftpd.tcl,v
retrieving revision 1.10
diff -r1.10 ftpd.tcl
108d107
<     namespace export fsFile::docRoot fsFile::fs
658c657,659
<     namespace export *
---
>     namespace export ABOR APPE CDUP CWD DELE HELP LIST MDTM MKD NOOP
>     namespace export NLST PASS PORT PWD QUIT REIN RETR RMD RNFR RNTO
>     namespace export SIZE STOR STOU SYST TYPE USER
1627c1628
<     namespace export *
---
>     namespace export docRoot fs
godel:48>
User Comments: andreas_kupries added on 2001-09-08 05:22:31:
Logged In: YES 
user_id=75003

Committed to head.

andreas_kupries added on 2001-09-08 05:20:50:

File Added - 10512: 459197.diff.2

Logged In: YES 
user_id=75003

Added the modified patch.

andreas_kupries added on 2001-09-08 05:15:50:
Logged In: YES 
user_id=75003

The author is/was Steffen Traeger who is interested
in other things now and there is no official maintainer.
(tcllib does not have such a big structure like tcl).

Ok, I leave ABOR etc. out of the export, docRoot and fs in.

hemanglavana added on 2001-09-07 01:19:50:
Logged In: YES 
user_id=81875

Perhaps not ... I wasn't sure abourt ABOR, etc so I just included them. 
I am not also sure whether docRoot and fs are exported or not.
If we refer to ftpd docs (http://tcllib.sourceforge.net/doc/ftpd.html) it provides only two
two public APIs ::ftpd::server and ::ftpd::config.

So, I will leave it upto the author/maintener to decide which APIs to export.

andreas_kupries added on 2001-09-07 01:05:18:
Logged In: YES 
user_id=75003

Hm. Are the implementations of the ftp commands (ABOR, etc) 
public API ? I thought not. They are accessed directly from 
the other parts of the demon and I would not export them.

andreas_kupries added on 2001-09-07 00:02:22:

File Added - 10449: 459197.diff

Logged In: YES 
user_id=75003

Added file containing the patch from the description.

Attachments: