Tk Library Source Code

View Ticket
Login
Ticket UUID: 3575707
Title: add opt arg to csv::join to force insertion of delimiter
Type: Bug Version: None
Submitter: gahr Created on: 2012-10-09 10:33:32
Subsystem: csv Assigned To: andreas_kupries
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2013-01-09 05:39:15
Resolution: Accepted Closed By: andreas_kupries
    Closed on: 2013-01-08 22:18:07
Description:
the proc ::csv::join currently surrounds values by the delimiter characters only when a value contains the delimiter. The patch attached adds an optional argument to ::csv::join, ::csv::joinlist, and ::csv:joinmatrix to make ::csv::join always surround fields by the delimiter character.
User Comments: andreas_kupries added on 2013-01-09 05:39:15:
Committed revision is  [c4c97db78e].

andreas_kupries added on 2013-01-09 05:18:07:

allow_comments - 1

andreas_kupries added on 2013-01-09 05:18:06:
Accepted with some changes:
- New version is 0.8, as this is a new feature, i.e. backward compatible API extension. Not a bugfix.
- The argument is called 'delMode' instead of 'forceDel'. The original name evokes a boolean flag, which the argument is not.
- The default value is "auto" for the existing behaviour.
- The new behaviour is activated for delMode == "always".
- Added a test case.
- Because of the use of "ne" ("eq" respectively) version 0.8 requires Tcl 8.4 instead of 8.3.

gahr added on 2012-10-09 17:33:33:

File Added - 454585: csv.diff

Attachments: