Tk Library Source Code

View Ticket
Login
Ticket UUID: 3553350
Title: htmlparse does't handle callback command containing "&"
Type: Bug Version: None
Submitter: dvrsn Created on: 2012-08-01 22:50:32
Subsystem: htmlparse Assigned To: andreas_kupries
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2012-08-03 05:22:39
Resolution: Fixed Closed By: andreas_kupries
    Closed on: 2012-08-02 22:22:39
Description:
If the callback command contains a "&" character, it is treated as part of the regular expression substitution string and ends up creating incorrect commands.   The same likely happens if the command contains \0 or similar sequences special to regsub.

htmlparse should escape any special characters in the command before creating the substitution string.
User Comments: andreas_kupries added on 2012-08-03 05:22:39:

allow_comments - 1

Applied patch in CVS head, package version is 1.2.1.

andreas_kupries added on 2012-08-03 05:07:46:
Thanks.

dvrsn added on 2012-08-03 03:42:33:
Testcase attached.

This new test passes with your patch.

dvrsn added on 2012-08-03 03:41:28:

File Added - 450448: htmlparse-test1.test

andreas_kupries added on 2012-08-03 00:49:10:
Attached a patch (unified diff) of a possible fix for this.
Please test.
If possible please provide a small test script demonstrating the issue also.
Something I can add to the package's testsuite.

andreas_kupries added on 2012-08-03 00:47:54:

File Added - 450432: htmlparse.patch

Attachments: