Tk Library Source Code

View Ticket
Login
Ticket UUID: 2123397
Title: bad [string first] in [::ip::version]
Type: Bug Version: None
Submitter: dgp Created on: 2008-09-22 21:03:21
Subsystem: ip Assigned To: andreas_kupries
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2009-04-14 03:34:09
Resolution: Accepted Closed By: andreas_kupries
    Closed on: 2009-04-13 20:33:51
Description:

In the proc ::ip::version, I see:

    if {[string first $addr :] < 0 && [IPv4? $addr]} {
        set version 4

where the arguments to [string first]
appear to be out of order.
User Comments: andreas_kupries added on 2009-04-14 03:34:09:
Committed change to head, ip 1.1.3.

andreas_kupries added on 2009-04-14 03:33:51:

allow_comments - 1

andreas_kupries added on 2009-04-14 03:09:01:
Yes. They are out of order.

The fact that this always failed however had no influence on the result. It simply defered to [IPv4?] and that did the right thing.

It seems that this was some attempt at a speed optimization, with [IPv4?] defering to the (presumably) expensive [Normalize4] and catching its ok/error.

We can either drop thisd check entirely, or maybe make it a part of IPv4?, suitable corrected.
I am currently leaning towards the latter.

dgp added on 2009-04-11 03:26:53:
status?