Tk Library Source Code

View Ticket
Login
Ticket UUID: 1969847
Title: Testsuite failures
Type: Bug Version: None
Submitter: andreas_kupries Created on: 2008-05-22 19:18:16
Subsystem: yaml Assigned To: kanryu6
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2009-07-05 10:06:52
Resolution: Fixed Closed By: kanryu6
    Closed on: 2008-10-10 05:01:40
Description:
Attached a quick run of the testsuite.

It seems that a 'switch' command in yaml is not protected against the occurrence of '-' in its input, leading to misinterpretation as option.

I.e. the code contains

    switch $ch

and it should better be

   switch -- $ch
User Comments: kanryu6 added on 2008-05-24 04:39:31:
Logged In: YES 
user_id=2072360
Originator: NO

modified these "switch"es.

And syntax checked with frink and nagelfar.
Almost all syntax holls are maybe modified.
But I don't have tclchecker.(within Tcl Dev Kit?)
So not checked with it. sorry.

kanryu6 added on 2008-05-24 04:38:33:
Logged In: YES 
user_id=2072360
Originator: NO

modified these "switch"es.

And syntax checked with frink and nagelfar.
Almost all syntax holls are maybe modified.
But I don't have tclchecker.(within Tcl Dev Kit?)
So not checked with it. sorry.

kanryu6 added on 2008-05-24 04:35:04:
Logged In: YES 
user_id=2072360
Originator: NO

modified these "switch"es.

And syntax checked with frink and nagelfar.
Almost all syntax holls are maybe modified.
But I don't have tclchecker.(within Tcl Dev Kit?)
So not checked with it. sorry.

kanryu6 added on 2008-05-23 22:28:12:
Logged In: YES 
user_id=2072360
Originator: NO

oh!
I begin to touch up them...

andreas_kupries added on 2008-05-23 02:22:54:
Logged In: YES 
user_id=75003
Originator: YES

This is confirmed when doing a syntax check with tclchecker of Tcl Dev Kit

andreask@gila:~/workbench/tcllib-head/tcllib> echo;./sak.tcl validate syntax -v modules/yaml/|grep WARN|grep warnDoubleDash

@@ WARN  yaml.tcl: 198 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 273 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 397 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 453 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 481 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 526 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 605 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 644 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 718 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 744 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 782 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 790 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 831 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 911 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch
@@ WARN  yaml.tcl: 940 (warnDoubleDash) Use -- before this computed word to prevent its possible misinterpretation as switch

andreas_kupries added on 2008-05-23 02:18:18:

File Added - 278707: yaml-testsuite-failures.log

Attachments: