Tk Library Source Code

View Ticket
Login
Ticket UUID: 1869943
Title: base64::decode fails while decoding invalid base64 strings
Type: Bug Version: None
Submitter: billiob Created on: 2008-01-12 14:06:08
Subsystem: base64 Assigned To: andreas_kupries
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2008-01-27 06:18:25
Resolution: Rejected Closed By: patthoyts
    Closed on: 2008-01-26 23:18:25
Description:
base64::decode fails while decoding invalid base64 strings.
If the string is "=" or "àà=" or "{what ever you want invalid base64 characters}={what ever you want}", it will bug when reading the "=" character.

With the patch, it will return the empty string.
User Comments: patthoyts added on 2008-01-27 06:18:24:
Logged In: YES 
user_id=202636
Originator: NO

You have [catch] for dealing with errors raised. Garbage in should be considered an error.

mic42 added on 2008-01-15 03:41:31:
Logged In: YES 
user_id=302287
Originator: NO

Its probably not a good idea to mask an error (and feeding junk into the decoder is clearly an error) by simply returning an empty string.

billiob added on 2008-01-12 21:06:10:

File Added - 261921: base64.tcl.patch

Attachments: