| Ticket UUID: | 1398330 | |||
| Title: | memchan-based vfs compatibility patch | |||
| Type: | Patch | Version: | None | |
| Submitter: | a_kovalenko | Created on: | 2006-01-06 07:40:55 | |
| Subsystem: | tklib: ico | Assigned To: | afaupell | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2006-07-15 09:26:13 | |
| Resolution: | Fixed | Closed By: | afaupell | |
| Closed on: | 2006-07-15 02:26:13 | |||
| Description: |
The issue was discovered when I was trying to generate an icon dynamically and place it into in-memory vfs. writeIconICO does a wrong thing when [file size] is not updated immediately as the file is written. Many VFSs implemented at the script level update file metadata only on [close], when the appropriate callback is called. Before closing the file, we may write 6 bytes in it and still get [file size]==0. The patch presented here prevents writeIconICO from relying on [file size] of the newly-created file. As long as the ICO format is the only one that may be created from scratch, no issues with other formats are expected. | |||
| User Comments: |
afaupell added on 2006-07-15 09:26:12:
Logged In: YES user_id=812825 thanks for the patch but the file size check was simply removed. a_kovalenko added on 2006-01-06 14:40:56: File Added - 162361: ico-vfs.diff | |||
Attachments:
- ico-vfs.diff [download] added by a_kovalenko on 2006-01-06 14:40:56. [details]