| Ticket UUID: | 3609342 | |||
| Title: | dtplite should not generate keyword link if no keywords | |||
| Type: | RFE | Version: | None | |
| Submitter: | apnadkarni | Created on: | 2013-03-28 10:12:46 | |
| Subsystem: | doctools | Assigned To: | andreas_kupries | |
| Priority: | 7 High | Severity: | ||
| Status: | Closed | Last Modified: | 2013-04-04 23:21:32 | |
| Resolution: | Closed By: | andreas_kupries | ||
| Closed on: | 2013-04-04 16:21:32 | |||
| Description: |
When the manpages do not define any keywords, the Keyword index links takes you to a blank page. I prefer the keyword link to be only generated if at least one keyword is present. Of course, some might say every page must have a keyword but I happen to disagree :-) I have a patch for this. Will submit after further testing. | |||
| User Comments: |
andreas_kupries added on 2013-04-04 23:21:32:
allow_comments - 1 Committed: http://core.tcl.tk/tcllib/info/7593991c41 (Updates to collateral, bumped version to 1.1). Merged: http://core.tcl.tk/tcllib/info/c148f532c8 Pushed. Completed. andreas_kupries added on 2013-04-04 22:52:24: Thanks you for testing. Will merge ASAP. apnadkarni added on 2013-04-04 15:04:53: Just tried it out, with and without keywords, with and without -merge option, and seems to work as desired in all cases. Thanks! apnadkarni added on 2013-04-04 14:47:32: Thanks, will try it out. The reason for the extraneous kwpresent was that with -merge option I was finding kwid always empty. Perhaps I was looking in the wrong spot. Will try your changes and let you know. /Ashok andreas_kupries added on 2013-04-04 11:12:02: Thanks for the patch.
I applied it now, with changes.
See branch "apn-dtplite-kwlinks", revision http://core.tcl.tk/tcllib/info/44d847703f
Please test if my changes still work for you.
(1) Fixed your bug-fix in "HeaderSetup", added comments explaining the conditions.
(2) Disabled "IdxWrite" when no keywords were found.
This means that not only the navbar links are gone, but the essentially empty "index.html" as well.
(3) Consolidated the check into a proc [HaveKeywords].
(4) Got rid of the superfluous "kwpresent" flag. We need only "kwid".
andreas_kupries added on 2013-04-01 23:46:17: Thank you Ashok. Will have a look in the next days. apnadkarni added on 2013-03-31 23:53:38: Patch is attached that will not generate links to keyword page if no keywords are defined. apnadkarni added on 2013-03-31 23:52:32: File Added - 462125: dtplite.tcl.patch | |||
Attachments:
- dtplite.tcl.patch [download] added by apnadkarni on 2013-03-31 23:52:31. [details]