Ticket UUID: | 3437641 | |||
Title: | new valtype function | |||
Type: | RFE | Version: | None | |
Submitter: | maxjarek | Created on: | 2011-11-14 07:51:57 | |
Subsystem: | valtype | Assigned To: | andreas_kupries | |
Priority: | 5 Medium | Severity: | ||
Status: | Closed | Last Modified: | 2011-11-17 02:10:08 | |
Resolution: | Closed By: | andreas_kupries | ||
Closed on: | 2011-11-16 19:10:08 | |||
Description: |
I prepare new valtype::iban file for validate Bank Identyficer Number. I think this is good add-ons for tcllib. | |||
User Comments: |
andreas_kupries added on 2011-11-17 02:10:08:
allow_comments - 1 Committed everything to CVS head. andreas_kupries added on 2011-11-17 02:05:19: Thank you. I have integrated this new version with the previous one, extending the range of checks a bit. I also moved some of the fixed values into type variables and simplified an expression, the check itself (nested expr is superfluous). One of the ibans in your tests is actually not correct, it seems: PL78102030170000270200618694 becomes 102030170000270200618694 PL78 becomes 102030170000270200618694 2521 78 % 97 == 46 != 1 (Confirmed using 'bc'). Spaces in the numbers just for clarity. I will take that as a test case of an incorrect number. maxjarek added on 2011-11-15 16:43:34: File Deleted - 428389: maxjarek added on 2011-11-15 16:43:14: File Added - 428477: valtype::iban.tcl maxjarek added on 2011-11-15 16:42:07: File Added - 428476: test.tcl maxjarek added on 2011-11-15 16:41:10: Yes, this is International_Bank_Account_Number. I attach new version function when i include references. I attach also test script for test correct iban numbers for some countries. I have only examples of correct IBANs. andreas_kupries added on 2011-11-14 23:24:43: Thank you. Is this the http://en.wikipedia.org/wiki/International_Bank_Account_Number ? (As you gave no reference I googled for IBAN and found the above). Do you have test cases as well, per chance, i.e. examples of correct and incorrect IBANs ? maxjarek added on 2011-11-14 14:51:58: File Added - 428389: valtype::iban.tcl |