Tk Library Source Code

View Ticket
Login
Ticket UUID: 3295abf0786394dc8bb96ecadc30ce4a57e6af0e
Title: ico: incorrect use of $img put
Type: Bug Version: trunk
Submitter: anonymous Created on: 2017-01-09 17:31:11
Subsystem: tklib :: ico Assigned To: aku
Priority: 8 Severity: Important
Status: Closed Last Modified: 2024-06-01 14:21:04
Resolution: Fixed Closed By: aku
    Closed on: 2024-06-01 14:21:04
Description: (text/x-fossil-wiki)
In the ico module there are the following four lines:

<verbatim>
/tklib-0.6/modules/ico/ico.tcl(557):	$img put -to 0 0 $colors
/tklib-0.6/modules/ico/ico.tcl(563):    $img put -to $x $y $clr
/tklib-0.6/modules/ico/ico0.tcl(400):	$img put -to 0 0 $colors
/tklib-0.6/modules/ico/ico0.tcl(406):	$img put -to $x $y $clr
</verbatim>

This is an incorrect use of the put command. Documentation says:

<b>imageName put data ?option value(s) ...? </b>

However the code in the ico module uses:

<b>imageName put ?option value(s) ...? data </b>

The latter used to be accepted, although undocumented, but will soon no longer be. See:

http://core.tcl.tk/tk/tktview?name=d4fb4e80d2

Fix is easy and consists in swapping the order of the data and the options arguments.
User Comments: aku added on 2024-06-01 14:21:04: (text/x-fossil-wiki)
Fixed with commit [590abe6a19].

Bumped to version 1.1.1.

Updated docs.

Thank you for the report and patience.