| Ticket UUID: | 2801896 | |||
| Title: | jpeg package: adds support for GPS Exif tags | |||
| Type: | Patch | Version: | None | |
| Submitter: | mdplumlee | Created on: | 2009-06-05 18:45:36 | |
| Subsystem: | jpeg | Assigned To: | andreas_kupries | |
| Priority: | 5 Medium | Severity: | ||
| Status: | Closed | Last Modified: | 2009-06-06 03:01:50 | |
| Resolution: | Accepted | Closed By: | andreas_kupries | |
| Closed on: | 2009-06-05 20:01:50 | |||
| Description: |
I needed something to interpret GPS tags in Exif headers, so I found the jpeg package and added it. Nice job whoever wrote the _exif routine--it was very easy to extend. I haven't done a patch before, so I'm probably doing it all wrong--I'm attaching the whole file I updated, and just put comments in the vicinity of my changes (I didn't comment the place where I added an optional argument...)--look for "mdp". | |||
| User Comments: |
andreas_kupries added on 2009-06-06 03:01:50:
allow_comments - 1
Accepted with slight changes. In CVS head, package version now is 0.3.5.
Changes:
Used hex tag 8825 for comparison, instead of name 'GPSInfo', like for the other special blocks. Moved the handling before the tag -> name conversion.
Replaced the 'eval "if ..."' contortion and quoting hell with, roughly
upvar 0 $use_tags thetags
if {[info exists thetags($tag)]|} ...
No eval required, no quoting hell.
mdplumlee added on 2009-06-06 01:45:37: File Added - 329887: jpeg.tcl | |||
Attachments:
- jpeg.tcl [download] added by mdplumlee on 2009-06-06 01:45:37. [details]