Tk Library Source Code

View Ticket
Login
Ticket UUID: 2123233
Title: bad [string first|last] syntax?
Type: Bug Version: None
Submitter: dgp Created on: 2008-09-22 19:03:57
Subsystem: yaml Assigned To: kanryu6
Priority: 5 Medium Severity:
Status: Closed Last Modified: 2009-07-05 10:07:13
Resolution: Fixed Closed By: kanryu6
    Closed on: 2008-09-26 17:33:49
Description:
This code in [::yaml::_getFoldedString]
looks suspcious:

 if {[string first $token "\n"] >= 0} { ; # multi-line
     set data(current) [expr {$len - [string last $token "\n"]}]


I suspect the arguments have their
order incorrect.  They should follow
the pattern:

 string first $needle $haystack

Searching for $token in the string "\n"
doesn't look right.  If it is right, a
comment of explanation would help.
User Comments: kanryu6 added on 2008-09-27 00:33:49:
Yes, that's right!

I fixed.
Thank you.