| Ticket UUID: | 1708110 | |||
| Title: | [png::removeComments] destroy a png file. | |||
| Type: | Bug | Version: | None | |
| Submitter: | nyademo | Created on: | 2007-04-26 14:42:54 | |
| Subsystem: | png | Assigned To: | afaupell | |
| Priority: | 7 High | Severity: | ||
| Status: | Closed | Last Modified: | 2007-05-01 06:02:53 | |
| Resolution: | Fixed | Closed By: | afaupell | |
| Closed on: | 2007-04-28 19:29:16 | |||
| Description: |
Hi. I noticed the bug that png::removeComments destroy a file. Version of png is CVS HEAD. It seems to me that the cause is that output encoding isn't binary. Please see attached patch. | |||
| User Comments: |
andreas_kupries added on 2007-05-01 06:02:53:
Logged In: YES user_id=75003 Originator: NO Updated testsuite now too. Won't fail for bug on unix, but does on win32, which is good enough for me. No need to fiddle with the system encoding. afaupell added on 2007-04-29 02:29:16: Logged In: YES user_id=812825 Originator: NO applied fix. thanks nyademo added on 2007-04-27 09:38:18: Logged In: YES user_id=932722 Originator: YES Hi. I had to write my environment first, sorry. It seems to me that the problem is not exists on the png file. It is on my japanese environment. cp932 is default encoding on windows. Maybe other languages have their own default encodings... It is a reason what output endoding must be binary. encoding system cp932 png::removeComments $file This code may enable you to find the bug. andreas_kupries added on 2007-04-27 01:06:49: Logged In: YES user_id=75003 Originator: NO nyademo, do you have a png file with which we can demo the problem and fix ? I am currently extending the testsuite to show problem and fix, and found that the 2 images which have comments we have here are not triggering the problem. Therefore unsuitable for testing. andreas_kupries added on 2007-04-27 00:40:59: Logged In: YES user_id=75003 Originator: NO I agree with the assessment. nyademo added on 2007-04-26 21:42:54: File Added - 226734: png.tcl.patch | |||
Attachments:
- png.tcl.patch [download] added by nyademo on 2007-04-26 21:42:54. [details]