Tk Library Source Code

View Ticket
Login
Ticket UUID: 1559489
Title: GUI Installer writes error only to stdout
Type: Bug Version: None
Submitter: mic42 Created on: 2006-09-15 17:22:58
Subsystem: Installer Assigned To: andreas_kupries
Priority: 7 High Severity:
Status: Closed Last Modified: 2006-09-19 22:22:11
Resolution: Fixed Closed By: andreas_kupries
    Closed on: 2006-09-19 15:22:11
Description:
The GUI mode installer.tcl terminates when it
encounters a non writable install location. So far so
good, but the error message only appears on stderr,
which is not optimal on windows where someone might
click on the installer.tcl file and start without
stderr. The installer should open a message box and
notify the user about the non writable location if in
GUI mode.
User Comments: andreas_kupries added on 2006-09-19 22:22:11:
Logged In: YES 
user_id=75003

Accepted with very small changes yesterday, committed this
morning. The nit, and slighty different formatting.

andreas_kupries added on 2006-09-19 06:23:03:
Logged In: YES 
user_id=75003

A quick look seems to be ok, only a nit: [catch {}] == 1 can
be shortened to [catch {...}] I do not thank that we care
about break, continue, etc. Will have a closer look when I
ma home, i.e. patch and look at the whole context.

mic42 added on 2006-09-19 06:01:53:

File Deleted - 194111: 



File Added - 194112: installer.tcl.diff

mic42 added on 2006-09-19 06:01:28:

File Added - 194111: installer.tcl

Logged In: YES 
user_id=302287

Diff adding an error dialog attached. Please review.

andreas_kupries added on 2006-09-19 03:08:39:
Logged In: YES 
user_id=75003

Michael, please investigate this and provide a patch.

Attachments: