Tk Library Source Code

Artifact [1836438720]
Login

Artifact 1836438720a00ac7ff1641d0e87352790a325394:

Attachment "472009_mime.diff" to ticket [472009ffff] added by andreas_kupries 2001-11-02 12:48:57.
Index: ChangeLog
===================================================================
RCS file: /cvsroot/tcllib/tcllib/ChangeLog,v
retrieving revision 1.68
diff -u -r1.68 ChangeLog
--- ChangeLog	2001/10/23 03:44:06	1.68
+++ ChangeLog	2001/11/02 05:47:02
@@ -1,3 +1,7 @@
+2001-11-01  Andreas Kupries  <[email protected]>
+
+	* mime: Fixed bugs #477088, #472009.
+
 2001-10-21  Andreas Kupries  <[email protected]>
 
 	* uri: Accepted patch #470211.
Index: modules/mime/ChangeLog
===================================================================
RCS file: /cvsroot/tcllib/tcllib/modules/mime/ChangeLog,v
retrieving revision 1.14
diff -u -r1.14 ChangeLog
--- modules/mime/ChangeLog	2001/10/17 17:27:26	1.14
+++ modules/mime/ChangeLog	2001/11/02 05:47:02
@@ -1,3 +1,17 @@
+2001-11-01  Andreas Kupries  <[email protected]>
+
+	* smtp.tcl: Fixed bug #472009. Changes in the handling of
+	  script-level transformations cause the system to try to
+	  initialize the read side of the 'smtp::wdata'
+	  transformation. This fails. Added a dummy create/read branch to
+	  the switch. Reported by 'nobody/anonymous', but possibly Andreas
+	  Otto (deduced from the specified example).
+
+	* mime.tcl: Added informaton about 7bit, 8bit, and binary encoding
+	  to the places where it is missing. This fixes SF item
+	  #477088. Bug was reported by Oliver Bienert
+	  <[email protected]>.
+
 2001-10-16  Andreas Kupries <[email protected]>
 
 	* mime.n:
Index: modules/mime/mime.tcl
===================================================================
RCS file: /cvsroot/tcllib/tcllib/modules/mime/mime.tcl,v
retrieving revision 1.16
diff -u -r1.16 mime.tcl
--- modules/mime/mime.tcl	2001/10/17 17:27:26	1.16
+++ modules/mime/mime.tcl	2001/11/02 05:47:02
@@ -318,7 +318,7 @@
 
             -encoding {
                 switch -- [set state(encoding) [string tolower $value]] {
-                    7bit - 8bit - quoted-printable - base64 {
+                    7bit - 8bit - binary - quoted-printable - base64 {
                     }
 
                     default {
@@ -1309,7 +1309,8 @@
                             set chunk [$state(encoding) -mode decode \
                                                         -- $chunk]
                         }
-			"" {
+			7bit - 8bit - binary - "" {
+			    # Bugfix for [#477088]
 			    # Go ahead, leave chunk alone
 			}
 			default {
@@ -1375,6 +1376,8 @@
                 }
 
                 default {
+		    # Not a bugfix for [#477088], but clarification
+		    # This handles no-encoding, 7bit, 8bit, and binary.
                     set fragment $state(string)
                 }
             }
@@ -1560,7 +1563,8 @@
                 quoted-printable {
                     set converter $encoding
                 }
-		"" {
+		7bit - 8bit - binary - "" {
+		    # Bugfix for [#477088]
 		    # Go ahead
 		}
 		default {
@@ -1798,7 +1802,8 @@
                 quoted-printable {
                     set converter $encoding
                 }
-		"" {
+		7bit - 8bit - binary - "" {
+		    # Bugfix for [#477088]
 		    # Go ahead
 		}
 		default {
Index: modules/mime/smtp.tcl
===================================================================
RCS file: /cvsroot/tcllib/tcllib/modules/mime/smtp.tcl,v
retrieving revision 1.14
diff -u -r1.14 smtp.tcl
--- modules/mime/smtp.tcl	2001/10/17 17:27:26	1.14
+++ modules/mime/smtp.tcl	2001/11/02 05:47:02
@@ -950,6 +950,8 @@
     upvar 0 $token state
 
     switch -- $command {
+	create/read
+	    -
         create/write
             -
         clear/write