Attachment "3532972fff.diff.txt" to
ticket [3532972fff]
added by
gahr
2016-05-13 16:10:33.
--- generic/threadSvCmd.c
+++ generic/threadSvCmd.c
@@ -57,10 +57,13 @@
/*
* Global variables used within this file.
*/
+static size_t nofThreads; /* Number of initialized threads */
+static Tcl_Mutex nofThreadsMutex; /* Protects the nofThreads variable */
+
static Bucket* buckets; /* Array of buckets. */
static Tcl_Mutex bucketsMutex; /* Protects the array of buckets */
static SvCmdInfo* svCmdInfo; /* Linked list of registered commands */
static RegType* regType; /* Linked list of registered obj types */
@@ -2128,10 +2131,17 @@
Bucket *bucketPtr;
SvCmdInfo *cmdPtr;
const Tcl_UniChar no[3] = {'n', 'o', 0} ;
Tcl_Obj *obj;
+ /*
+ * Increment number of threads
+ */
+ Tcl_MutexLock(&nofThreadsMutex);
+ ++nofThreads;
+ Tcl_MutexUnlock(&nofThreadsMutex);
+
/*
* Add keyed-list datatype
*/
TclX_KeyedListInit(interp);
@@ -2187,11 +2197,13 @@
if (buckets == NULL) {
Tcl_MutexLock(&bucketsMutex);
if (buckets == NULL) {
buckets = (Bucket *)ckalloc(sizeof(Bucket) * NUMBUCKETS);
+#ifdef SV_FINALIZE
Tcl_CreateExitHandler(SvFinalize, NULL);
+#endif
for (i = 0; i < NUMBUCKETS; ++i) {
bucketPtr = &buckets[i];
memset(bucketPtr, 0, sizeof(Bucket));
Tcl_InitHashTable(&bucketPtr->arrays, TCL_STRING_KEYS);
@@ -2256,10 +2268,22 @@
SvCmdInfo *cmdPtr;
RegType *regPtr;
Tcl_HashEntry *hashPtr;
Tcl_HashSearch search;
+
+ /*
+ * Decrement number of threads. Proceed only if I was the last one. The
+ * mutex is unlocked at the end of this function, so new threads that might
+ * want to register in the meanwhile will find a clean environment when
+ * they eventually succeed acquiring nofThreadsMutex.
+ */
+ Tcl_MutexLock(&nofThreadsMutex);
+ if (nofThreads > 1)
+ {
+ goto done;
+ }
/*
* Reclaim memory for shared arrays
*/
@@ -2317,10 +2341,14 @@
}
regType = NULL;
}
Tcl_MutexUnlock(&svMutex);
+
+done:
+ --nofThreads;
+ Tcl_MutexUnlock(&nofThreadsMutex);
}
#endif /* SV_FINALIZE */
/* EOF $RCSfile: threadSvCmd.c,v $ */