Check-in [50d8da007b]
Bounty program for improvements to Tcl and certain Tcl packages.
Overview
Comment:Reverted [f79122ae17]
Downloads: Tarball | ZIP archive | SQL archive
Timelines: family | ancestors | descendants | both | trunk
Files: files | file ages | folders
SHA1: 50d8da007b4ae9fce0f8f10a253e3ec3031eb190
User & Date: rkeene on 2016-12-13 15:29:19
Other Links: manifest | tags
Context
2016-12-13
15:43
Made repeated failures to handshake return fatal errors and made handshake code use the same logic as the rest of the OpenSSL read error checking check-in: 1b7959d27a user: rkeene tags: trunk
15:29
Reverted [f79122ae17] check-in: 50d8da007b user: rkeene tags: trunk
08:48
Updated to fatally fail if the handshake fatally fails check-in: f79122ae17 user: rkeene tags: trunk
Changes

Modified tlsIO.c from [3765b3df61] to [cd83a9c489].

   213    213   	}
   214    214   
   215    215   	dprintf("Calling Tls_WaitForConnect");
   216    216   	tlsConnect = Tls_WaitForConnect(statePtr, errorCodePtr);
   217    217   	if (tlsConnect < 0) {
   218    218   		dprintf("Got an error waiting to connect (tlsConnect = %i, *errorCodePtr = %i)", tlsConnect, *errorCodePtr);
   219    219   
   220         -		if (statePtr->flags & TLS_TCL_HANDSHAKE_FAILED) {
   221         -			dprintf("The handshake completely failed, returning in failure");
   222         -			return(-1);
   223         -		}
   224         -
   225    220   		bytesRead = -1;
   226    221   		if (*errorCodePtr == ECONNRESET) {
   227    222   			dprintf("Got connection reset");
   228    223   			/* Soft EOF */
   229    224   			*errorCodePtr = 0;
   230    225   			bytesRead = 0;
   231    226   		}
................................................................................
   342    337   	}
   343    338   
   344    339   	dprintf("Calling Tls_WaitForConnect");
   345    340   	tlsConnect = Tls_WaitForConnect(statePtr, errorCodePtr);
   346    341   	if (tlsConnect < 0) {
   347    342   		dprintf("Got an error waiting to connect (tlsConnect = %i, *errorCodePtr = %i)", tlsConnect, *errorCodePtr);
   348    343   
   349         -		if (statePtr->flags & TLS_TCL_HANDSHAKE_FAILED) {
   350         -			dprintf("The handshake completely failed, returning in failure");
   351         -			return(-1);
   352         -		}
   353         -
   354    344   		written = -1;
   355    345   		if (*errorCodePtr == ECONNRESET) {
   356    346   			dprintf("Got connection reset");
   357    347   			/* Soft EOF */
   358    348   			*errorCodePtr = 0;
   359    349   			written = 0;
   360    350   		}