History Of Ticket 47edc4cb21e0add7
Bounty program for improvements to Tcl and certain Tcl packages.

Artifacts Associated With Ticket 47edc4cb21e0add7

  1. Ticket change [d13e31ddb2] (rid 1251) by anonymous on 2017-01-17 11:00:04:

    1. icomment:
      I suggest the following change, to avoid unnecessary temporary files at build time.
      
      Index: Makefile.in
      ==================================================================
      --- Makefile.in
      +++ Makefile.in
      @@ -36,14 +36,12 @@
      
       # Create a C-source-ified version of the script resources
       # for TclTLS so that we only need a single file to enable
       # this extension
       tls.tcl.h: @[email protected]/tls.tcl Makefile
      -       od -A n -v -t xC < '@[email protected]/tls.tcl' > tls.tcl.h.new.1
      -       sed '[email protected]  *@@g;[email protected]@0x&, @g' < tls.tcl.h.new.1 > tls.tcl.h.new.2
      -       rm -f tls.tcl.h.new.1
      -       mv tls.tcl.h.new.2 tls.tcl.h
      +       od -A n -v -t xC < '@[email protected]/tls.tcl' | \
      +       sed '[email protected]  *@@g;[email protected]@0x&, @g' > tls.tcl.h
      
       # Create default DH parameters
       dh_params.h: @[email protected]/gen_dh_params Makefile
              @[email protected]/gen_dh_params @[email protected] > dh_params.h.new
              mv dh_params.h.new dh_params.h
      
    2. login: "anonymous"
    3. mimetype: "text/x-fossil-plain"
    4. private_contact initialized to: "438e59f1f1c891b29d2528ed82d1e629cecc6336"
    5. severity initialized to: "Minor"
    6. status initialized to: "Open"
    7. title initialized to: "Avoid unnecessary temporary files at build time"
    8. type initialized to: "Build Problem"
  2. Ticket change [63401761f5] (rid 1252) by rkeene on 2017-01-17 14:42:59:

    1. icomment:
      The reason it's done this way is because the exit status is only of the last command in the pipeline.
      
      Your solution will only fail if 'sed' fails, not if 'od' fails.  The result will appear to be successful but be a zero byte file.
      
    2. login: "rkeene"
    3. mimetype: "text/html"
    4. priority changed to: "Immediate"
    5. resolution changed to: "Open"
  3. Ticket change [b9a268b66a] (rid 1254) by rkeene on 2017-01-17 15:44:50:

    1. login: "rkeene"
    2. mimetype: "text/x-fossil-plain"
    3. resolution changed to: "Rejected"
    4. status changed to: "Closed"