D 2024-10-04T07:23:36.353
J foundin 1505883e4a\sfrom\s2024-07-01
J icomment Compiling\stls.c\son\smacoS\s(17.0/arm)\syields\sthe\sfollowing\swarnings\swhich\sI\sassume\sare\serrors:\r\n```\r\n/opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:1769:18:\swarning:\svariable\s'abort'\sset\sbut\snot\sused\s[-Wunused-but-set-variable]\r\n\s1769\s|\s\s\s\s\sint\soff\s=\s0,\sabort\s=\s0;\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s^\r\n/opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2222:11:\swarning:\suse\sof\slogical\s'&&'\swith\sconstant\soperand\s[-Wconstant-logical-operand]\r\n\s2222\s|\s\s\s\s\s\s\s\s\sif\s(mode\s&&\sSSL_VERIFY_FAIL_IF_NO_PEER_CERT)\s{\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s^\s\s~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n/opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2222:11:\snote:\suse\s'&'\sfor\sa\sbitwise\soperation\r\n\s2222\s|\s\s\s\s\s\s\s\s\sif\s(mode\s&&\sSSL_VERIFY_FAIL_IF_NO_PEER_CERT)\s{\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s^~\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s&\r\n/opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2222:11:\snote:\sremove\sconstant\sto\ssilence\sthis\swarning\r\n\s2222\s|\s\s\s\s\s\s\s\s\sif\s(mode\s&&\sSSL_VERIFY_FAIL_IF_NO_PEER_CERT)\s{\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n/opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2225:11:\swarning:\suse\sof\slogical\s'&&'\swith\sconstant\soperand\s[-Wconstant-logical-operand]\r\n\s2225\s|\s\s\s\s\s\s\s\s\sif\s(mode\s&&\sSSL_VERIFY_CLIENT_ONCE)\s{\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s^\s\s~~~~~~~~~~~~~~~~~~~~~~\r\n/opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2225:11:\snote:\suse\s'&'\sfor\sa\sbitwise\soperation\r\n\s2225\s|\s\s\s\s\s\s\s\s\sif\s(mode\s&&\sSSL_VERIFY_CLIENT_ONCE)\s{\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s^~\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s&\r\n/opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2225:11:\snote:\sremove\sconstant\sto\ssilence\sthis\swarning\r\n\s2225\s|\s\s\s\s\s\s\s\s\sif\s(mode\s&&\sSSL_VERIFY_CLIENT_ONCE)\s{\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s^~~~~~~~~~~~~~~~~~~~~~~~~\r\n/opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2228:11:\swarning:\suse\sof\slogical\s'&&'\swith\sconstant\soperand\s[-Wconstant-logical-operand]\r\n\s2228\s|\s\s\s\s\s\s\s\s\sif\s(mode\s&&\sSSL_VERIFY_POST_HANDSHAKE)\s{\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s^\s\s~~~~~~~~~~~~~~~~~~~~~~~~~\r\n/opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2228:11:\snote:\suse\s'&'\sfor\sa\sbitwise\soperation\r\n\s2228\s|\s\s\s\s\s\s\s\s\sif\s(mode\s&&\sSSL_VERIFY_POST_HANDSHAKE)\s{\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s^~\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s&\r\n/opt/projects/prs/g481/src/tcltls-1505883e4a/generic/tls.c:2228:11:\snote:\sremove\sconstant\sto\ssilence\sthis\swarning\r\n\s2228\s|\s\s\s\s\s\s\s\s\sif\s(mode\s&&\sSSL_VERIFY_POST_HANDSHAKE)\s{\r\n\s\s\s\s\s\s|\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s^~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n4\swarnings\sgenerated.\r\n```\r\nFix:\r\nChange\sthe\s'&&'\sinto\s'&'\ssince\sthe\sopenssl\sfunction\sreturns\san\sint\scontaining\sa\sbitmask.\sI\sam\snot\sconverned\sabout\sthe\sunused\svariable\s`abort`.\sI\sapplied\sthis\smodificationlocally\sand\severything\sseems\sto\swork\scorrectly.
J login anonymous
J mimetype text/x-markdown
J private_contact 720cbbf8ba21fd6982dfd8639b4ecf45d5cf11a3
J severity Severe
J status Open
J title Error\sin\smode\schecking\sin\slatest\schckin\s1505883e4a\sfrom\s2024-07-01
J type Code\sDefect
K fee1ffa1b6037cb15b592ad550d21760e1548eda
U anonymous
Z 2a4c8467ce3eb61fb8f837e8e822264c