2000-07-26 Jeff Hobbs <[email protected]>
* tests/tlsIO.test: updated comments, fixed a pcCrash case that
was due to debug assertion in Windows SSL.
* tls.c (ImportObjCmd): removed unnecessary use of 'bio' arg.
(Tls_Init): check return value of SSL_library_init. Also lots of
whitespace cleanup (more like Tcl Eng style guide), but not all
code was cleaned up.
* tlsBIO.c: minor whitespace cleanup
* tlsIO.c: minor whitespace cleanup.
(TlsInputProc, TlsOutputProc): Added ERR_clear_error before calls
to BIO_read or BIO_write, because we could otherwise end up
pulling an error off the stack that didn't belong to us. Also
cleanup up excessive use of gotos.
2000-07-20 Jeff Hobbs <[email protected]>
* tests/tlsIO.test: corrected various tests to be correct for TLS
stacked channels (as opposed to the standard sockets the test
suite was adopted from). Key differences are that TLS cannot
operate in one process without all channels being non-blocking, or
the handshake will block, and handshaking must be forced in some
cases. Also, handshakes don't seem to complete unless the client
has placed at least one byte for the server to read in the channel.
* tests/remote.tcl: corrected the finding of tests certificates
* tlsIO.c (TlsCloseProc): removed deleting of timer handler as
that is handled by Tls_Clean.
* tls.tcl (tls::_accept): corrected the internal _accept to
trickle callback errors to the user.
* Makefile.in: made the install-binaries target regenerate the
pkgIndex.tcl correctly. The test target probably shouldn't screw
it up, but this is to be on the safe side.
2000-07-17 Jeff Hobbs <[email protected]>
* configure.in: updated version to 1.4
2000-07-13 Jeff Hobbs <[email protected]>
* tests/tlsIO.test: enabled tests 2.10, 7. (there is no 3),
which now pass. Added some comments to other failing tests.
2000-07-11 Jeff Hobbs <[email protected]>
* tlsIO.c: changed all the channel procs to start with Tls* for
better parity when comparing with Transform channel procs.
Rewrote TlsWatchProc, added TlsNotifyProc according to the new
channel design, which also leaves TlsChannelHandler unused.
* tlsBIO.c (BioCtrl): changed BIO_CTRL_FLUSH case to use
Tcl_WriteRaw instead of Tcl_Flush (to operate on correct channel
in the stack instead of starting at the top again). Would
otherwise cause a recursive stack bomb when implicit handshaking
* tests/tlsIO.test: removed changes made to test suite (all tests
that ran before now pass correctly), and changed some accept proc
args to reflect that a sock is an arg, not a file.
2000-07-10 Jeff Hobbs <[email protected]>
* tlsBIO.c (BioWrite, BioRead): changed Tcl_Read/Write to
* tls.c: added use of Tcl_GetTopChannel after Tcl_GetChannel and
got return value from Tcl_StackChannel.
* tests/tlsIO.test: added some handshaking that shouldn't be
necessary, but we crash otherwise (needs more testing).
* tlsIO.c: added support for "corrected" stacked channels. All
the above channels are in TCL_CHANNEL_VERSION_2 #ifdefs.
2000-06-05 Scott Stanton <[email protected]>
* Makefile.in: Fixed broken test target.
* tls.c: Cleaned up declarations of Tls_Clean to avoid errors on
2000-06-05 Brent Welch <[email protected]>
* tls.c, tlsIO.c: Split Tls_Free into Tls_Clean, which does
the SSL cleanup, and the Tcl_Free call. It is important to shutdown
the SSL state "synchronously" during a stacked flush.
2000-06-01 Scott Stanton <[email protected]>
* tlsIO.c: Restored call to Tcl_NotifyChannel from ChannelHandler
to ensure that events propagate from the lower driver. This may
result in an infinite loop in some cases, so this is not a total
fix. This may be sufficient for now, however. [Bug: 5623]
2000-06-01 Scott Stanton <[email protected]>
* tlsIO.c: Restore the previous version. Fixed the CloseProc so
it unregisters the channel handler on the superceded channel
instead of the upper channel. Also removed the call to
Tcl_NotifyChannel in the ChannelHandler because this will result
in an infinite loop if data is ever buffered in the BIO
structure. [Bug: 5623]
2000-05-31 Brent Welch <[email protected]>
* tls.c: Change the ChannelHandler to be registered on the main
channel as oppsed to the "parent", or superceeded, channel. This
is because the socket driver notifies the main channel, and there
are times with the main channel gets closed, but the superceded
one is not yet closed. If the channel handler gets triggered in
this half-open state it is associated with the superceeded
channedl, but uses its private pointer to the main channel, which
is mostly destroyed. Eliminated the redundant call to
Tcl_NotifyChannel from TlsWatchProc. [Bug: 5623]