Artifact [ea32995d09]

Artifact ea32995d09416460d24cc4fc4ff18e296d82ec7b563b69d5b563af3947979918:

Ticket change [ea32995d09] - New ticket [539d25f105a84615|539d25f105] <i>The isServer argument of CTX_Init() is unused</i>. by doofus on 2023-11-20 02:46:47.
D 2023-11-20T02:46:47.201
J foundin 1.7.22
J icomment Compiler\swarns\sof\sthe\s`isServer`\sfunction\sparameter\sbeing\sunused.\sSeems\slike\sit\scan,\sindeed,\sbe\ssafely\sremoved:\r\n\r\n```patch\r\n---\stls.c\s\s\s\s\s\s\s2020-10-12\s16:39:22.000000000\s-0400\r\n+++\stls.c\s\s\s\s\s\s\s2023-11-19\s21:30:03.357601000\s-0500\r\n@@\s-62,5\s+62,5\s@@\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sTcl_Interp\s*interp,\sint\sobjc,\sTcl_Obj\s*CONST\sobjv[]);\r\n\r\n-static\sSSL_CTX\s*CTX_Init(State\s*statePtr,\sint\sisServer,\sint\sproto,\schar\s*key,\r\n+static\sSSL_CTX\s*CTX_Init(State\s*statePtr,\sint\sproto,\schar\s*key,\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\schar\s*certfile,\sunsigned\schar\s*key_asn1,\sunsigned\schar\s*cert_asn1,\r\n\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\s\sint\skey_asn1_len,\sint\scert_asn1_len,\schar\s*CAdir,\schar\s*CAfile,\r\n@@\s-897,5\s+897,5\s@@\r\n\s\s\s\s\s\s\s\sctx\s=\s((State\s*)Tcl_GetChannelInstanceData(chan))->ctx;\r\n\s\s\s\s\s}\selse\s{\r\n-\s\s\s\s\s\s\sif\s((ctx\s=\sCTX_Init(statePtr,\sserver,\sproto,\skeyfile,\scertfile,\skey,\r\n+\s\s\s\s\s\s\sif\s((ctx\s=\sCTX_Init(statePtr,\sproto,\skeyfile,\scertfile,\skey,\r\n\s\s\s\s\scert,\skey_len,\scert_len,\sCAdir,\sCAfile,\sciphers,\r\n\s\s\s\s\sDHparams))\s==\s(SSL_CTX*)0)\s{\r\n@@\s-1067,8\s+1067,7\s@@\r\n\r\n\sstatic\sSSL_CTX\s*\r\n-CTX_Init(statePtr,\sisServer,\sproto,\skeyfile,\scertfile,\skey,\scert,\r\n+CTX_Init(statePtr,\sproto,\skeyfile,\scertfile,\skey,\scert,\r\n\s\s\s\s\s\s\s\s\s\skey_len,\scert_len,\sCAdir,\sCAfile,\sciphers,\sDHparams)\r\n\s\s\s\s\sState\s*statePtr;\r\n-\s\s\s\sint\sisServer;\r\n\s\s\s\s\sint\sproto;\r\n\s\s\s\s\schar\s*keyfile;\r\n```
J login doofus
J mimetype text/x-markdown
J private_contact 97c7e5a24584ec1fd28bf5cc453cd06585a9a915
J severity Critical
J status Open
J title The\sisServer\sargument\sof\sCTX_Init()\sis\sunused
J type Code\sDefect
K 539d25f105a84615256eff74bdf78baff7fd51e5
U doofus
Z a5bdb10ead5d5e377e496032b1e48111