D 2019-06-06T08:43:14.912
J assignee nobody
J closer nobody
J cmimetype text/plain
J comment Blowfish\spads\san\sincoming\sstream\simproperly.\sThis\swas\sseen\sand\sreported\sby\sJim\sin\sthis\sthread\son\scomp.lang.tcl:\r\nhttps://groups.google.com/forum/#!topic/comp.lang.tcl/XhDe5-yLzw0\r\n\r\nThe\simproper\spadding\shappens\sin\sthe\sprocedure\sblowfish::Chunk\swhich\salready\scontains\sa\sFIXME\scomment.\sThe\sprocedure\sneeds\sto\scare\sabout\s2\sthings:\r\n\r\n1.\sData\smust\salways\sbe\sprocessed\sin\smultiples\sof\s8\sbytes.\sHowever,\sit's\snot\sguaranteed\sthat\sa\smultiple\sof\s8\sbytes\sis\sread\seven\sin\sthe\smiddle\sof\sa\sstream.\sReasons\scan\sbe\san\sodd\suser\sprovided\schunk\ssize\sor\sa\snonblocking\schannel.\sMy\spatch\sintroduces\sa\snew\svariable\sstate(remainder)\sto\shold\sthe\smodulo\sdata.\r\n\r\n2.\sApply\spadding\sat\sthe\send\sof\sthe\sstream,\sand\sonly\sthere.\sDon't\spad\san\sempty\sstring.\sUnfortunately,\sblowfish::Pad\sis\sdoing\sexactly\sthis.\sI\sthink\san\sempty\sstring\sshould\snot\sbe\spadded.\sLikewise\san\sempty\sdata\sset\sencrpyts\sto\san\sempty\sdata\sset.\sIf\sthis\sis\snot\scorrect\sthen\sextra\scare\shas\sto\sbe\staken\swith\sthe\sremainig\sdata\sat\sEOF.\sAlso,\sblowfish::Chunk\sdidn't\scall\spad\swith\sthe\suser\sprovided\spad\scharacter.\r\n\r\nThe\sattached\spatch\stakes\scare\sof\sboth\spoints.\r\n\r\nMissing:\sA\stest\sfor\sthe\sinput\schannel\sAPI.\r\n\r\n--\sStephan\sEffelsberg
J foundin 1.0.4
J is_private 0
J login anonymous
J priority 5\sMedium
J private_contact 87a8af3af6267b859f2893f3f1d57a347c5b095a
J resolution None
J severity Minor
J status Open
J submitter anonymous
J subsystem blowfish
J title Incorrect\spadding\sof\sdata\swhen\susing\sinput\schannel
J type Bug
K d56da1abcaa028bed473ff5ffbd814f41909c5f5
U anonymous
Z 55cb12597b82070acbd66d24b5b7a7bf