| Ticket UUID: | d4e464ae4860404e197b4261960bafd27e93f972 | ||
| Title: | tcl 8.5.15/8.61 breaks python make check on darwin | ||
| Type: | Bug | Created on: | 2013-10-05 18:34:10 |
| Submitter: | jwhowarth | Assigned to: | jan.nijtmans |
| Subsystem: | 49. Threading | Severity: | Minor |
| Priority: | 5 Medium | Last modified: | 2013-11-11 12:28:18 |
| Status: | Closed | Closed by: | jan.nijtmans |
| Resolution: | Fixed | Closed on: | 2013-11-11 12:28:18 |
| Version: | 8.5.15/8.6.1 | ||
| Description: | ||||
On x86_64-apple-darwin11/12/13, the recent changes to tcl 8.5.15 and 8.6.1, when built with --enable-threads --disable-corefoundation', results in a hang in the python 2.7.5 make check. This appear as…
test_xpickle -- skipping backwards compat tests.
Use 'regrtest.py -u xpickle' to run them.
test_xrange
test_zipfile
test_zipfile64
test_zipfile64 skipped -- test requires loads of disk-space bytes and a long time to run
test_zipimport
test_zipimport_support
test_zlib
351 tests OK.
38 tests skipped:
test_aepack test_al test_applesingle test_bsddb185 test_bsddb3
test_cd test_cl test_codecmaps_cn test_codecmaps_hk
test_codecmaps_jp test_codecmaps_kr test_codecmaps_tw test_curses
test_dl test_epoll test_gdb test_gl test_imageop test_imgfile
test_largefile test_linuxaudiodev test_macos test_macostools
test_msilib test_ossaudiodev test_scriptpackages test_smtpnet
test_socketserver test_startfile test_sunaudiodev test_timeout
test_tk test_ttk_guionly test_urllib2net test_urllibnet
test_winreg test_winsound test_zipfile64
8 skips unexpected on darwin:
test_aepack test_applesingle test_bsddb185 test_dl test_macos
test_macostools test_scriptpackages test_ttk_guionly
where the python 2.7.5 make check hangs. I assume this is due to the change…
Limited support for fork() with threads. Enough for Rivet.
in 8.5.15/8.6.1 and that was only coded for '--enable-threads --enable-corefoundation' on darwin.
as this hang in the python 2.7.5 make check is eliminated when the installed tcl 8.5.15/8.6.1 is
built with those configure options. Apparently these changes weren't coded for handling the
corner case of '--enable-threads --disable-corefoundation' on darwin.
| ||||
| User Comments: | ||||
jan.nijtmans added on 2013-10-06 07:50:17:
Jeff, if you do exactly the same but then without '--disable-corefoundation', do the tests pass then? I would like to be absolutely sure that this option makes the change, not any other difference in your build/run environment. Thanks! jwhowarth added on 2013-10-06 15:57:18:
In fink, on darwin12, our tcltk package builds with the following configure commands… export COMMAND_MODE=legacy ./configure --prefix=/sw --enable-shared --enable-threads --disable-corefoundation --exec-prefix=/sw --mandir=/sw/share/man --x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib tcl_cv_type_64bit="long long" --build=x86_64-apple-darwin`uname -r|cut -f1 -d.` --host=x86_64-apple-darwin`uname -r|cut -f1 -d.` export DYLD_FALLBACK_LIBRARY_PATH=/sw/src/fink.build/tcltk-8.5.15-2/tcl8.5.15/unix ac_cv_path_tclsh=/sw/src/fink.build/tcltk-8.5.15-2/tcl8.5.15/unix/tclsh ./configure --prefix=/sw --enable-shared --enable-threads --disable-corefoundation --exec-prefix=/sw --mandir=/sw/share/man --x-includes=/usr/X11R6/include --x-libraries=/usr/X11R6/lib tcl_cv_type_64bit="long long" --build=x86_64-apple-darwin`uname -r|cut -f1 -d.` --host=x86_64-apple-darwin`uname -r|cut -f1 -d.` The resulting build completely passes the tcl test suite. Also, expect 5.45 built against this tcltk package and the same tcl/tk sources shows no failures in the expect test suite. jan.nijtmans added on 2013-10-06 19:40:09:
See [4b277b8c24] for my first fixing attempt. If I understand the problem correctly, somehow the Unix Notifier is used, even though it's on MacOSX. If that is correct, [4b277b8c24] might work by simply disabling the changes for MacOSX. Please provide feedback on this change, so we can see whether this helps or not. jwhowarth added on 2013-10-07 13:14:50:
Adding the proposed change from http://core.tcl.tk/tcl/info/4b277b8c24 to the fink tcltk-8.5.15 package produces no regressions in the tcl test suite when built with --enable-threads --disable-corefoundation or expect 5.45's test suite when rebuilt against those sources. This change also eliminates the hang in the python 2.7.5 test suite. Will test porting this change to tcl 8.6.1 next. jan.nijtmans added on 2013-10-07 14:25:28:
Thanks for your feedback! Fixed now in core-8-5-branch and trunk. jan.nijtmans added on 2013-11-11 12:28:18:
Related: [1470152] | ||||
