Tcl Source Code

View Ticket
Login
Ticket UUID: ebc39f14d75c1cfc8cd0840f8312b45b4f744b64
Title: OO-command implicit tracing
Type: Bug Created on: 2025-03-25 01:14:34
Submitter: sebres Assigned to: nobody
Subsystem: 35. TclOO Package Severity: Minor
Priority: 5 Medium Last modified: 2025-03-25 01:16:13
Status: Open Closed by: nobody
Resolution: None Closed on:
Version: 8.6+
Description:

The command of OO-object will be always created together with a rename/delete trace, that has a lot of adverse consequences:

  1. additional alloc/free per object
  2. unneeded effort by deletion due to untrace procedure
  3. tracing of command may cause extra overhead by evaluation, and needlessly burden the invocation of object and its methods
  4. due to this retarded by design clean-up via trace (and only one refCount for cmdPtr stored in object), it may cause usage after free for deleted oPtr->command (with Tcl_DeleteCommandFromToken, if it was last reference to the time of call ObjectNamespaceDeleted)
  5. oPtr->refCount is initially 2, with further cons, like potential leaks (either trace or command isn't involved in this refCount, otherwise it'd be 3 and not 2) or dereferencing by deletion is not really "atomic" or else may be semi-finished by refCount = 1;
  6. the trace is basically not really needed, because:
    • for deletion there is deleteProc-callback that one could set directly by creating of the OO-command
    • and renaming trace is currently used only to clean oPtr->cachedNameObj (if it is therel), this can be achieved by different approach, e.g. by checking of cmdEpoch (which gets incremented by rename) inside the TclOOObjectName);

I'll provide new branch without tracing in OO.