|
The command of OO-object will be always created together with a rename/delete trace, that has a lot of adverse consequences:
- additional alloc/free per object
- unneeded effort by deletion due to untrace procedure
- tracing of command may cause extra overhead by evaluation, and needlessly burden the invocation of object and its methods
- due to this retarded by design clean-up via trace (and only one refCount for cmdPtr stored in object), it may cause usage after free for deleted oPtr->command (with Tcl_DeleteCommandFromToken, if it was last reference to the time of call ObjectNamespaceDeleted)
- oPtr->refCount is initially 2, with further cons, like potential leaks (either trace or command isn't involved in this refCount, otherwise it'd be 3 and not 2) or dereferencing by deletion is not really "atomic" or else may be semi-finished by refCount = 1;
- the trace is basically not really needed, because:
- for deletion there is deleteProc-callback that one could set directly by creating of the OO-command
- and renaming trace is currently used only to clean oPtr->cachedNameObj (if it is therel), this can be achieved by different approach, e.g. by checking of cmdEpoch (which gets incremented by rename) inside the TclOOObjectName);
I'll provide new branch without tracing in OO.
|