Tcl Source Code

When passed as a file to tclsh, the following script, with <code>eva</code>
missing the final <code>l</code>, results in a segmentation fault:

<code><verbatim>
    namespace eva n1 {error hello}
</verbatim></code>

An alternate script that produces the same result is:

<code><verbatim>
    namespace eval n1 {
        namespace ensemble create
        namespace export *
        proc p1 args {error hello}
    }
    namespace eva n1 {::n1 p1}
</verbatim></code>

The reason is that <code>TclSpellFix</code> sets <code>NULL</code> as the first
object pointer in <code>iPtr->ensembleRewrite.sourceObjs</code> and then later,
in <code>NRNamespaceEvalCmd</code>, <code>TclFetchEnsembleRoot</code> copies a
pointer to this array into <code>framePtr->objv</code>. Next, when an error
occurs, <code>TclLogCommandInfo</code> accesses this array and trips on the
<code>NULL</code>, causing the segmentation fault.

Thanks! Closing

Fix merged to core-8-6-branch in [da5128637598b0f1].

Fix merged to core-8-branch in [bd393417060a158f].

Warning silenced in [d49a1b03291b4cde].

Windows build fails due to the the following warning, which is threated as an error in debug builds:
<pre>
D:\a\tcl\tcl\win\..\generic\tclEnsemble.c(2247): error C2220: the following warning is treated as an error
D:\a\tcl\tcl\win\..\generic\tclEnsemble.c(2247): warning C4047: '=': 'Tcl_Obj *const *' differs in levels of indirection from 'Tcl_Obj *const '
</pre>

Is this fix going to be backported to 8.7 -> 8.6 too?

Fixed in commit [a2e801a3d6c1675b].