Tcl Source Code

Just like [8ffd8cabd1], we expect all Tcl commands to give the same answer, whether the UTF-8 setting is available in the manifest or not.

Let's see if TIP #716 adhers to that:

>.\tclsh90
% tcl::build-info
9.0.2+af16c07b81655fabde8028374161ad54b84ef9956843c63f49976b4ef601b611.gcc-1002
% encoding user
cp1252
% exit

>.\wish90
% tcl::build-info
9.0.2+af16c07b81655fabde8028374161ad54b84ef9956843c63f49976b4ef601b611.gcc-1002
% encoding user
utf-8
% exit

We expect the same answer (cp1252) in both cases. If tcl90.dll is embedded in R, the same will happen in that environment (using wish90 here is just for demo purposes).

Note that wish90 has the UTF-8 setting in the manifest, tclsh90 has not (it's the TIP #716 implementation). The tcl dll (tcl90.dll) is the same in both cases.

TIP #718 doesn't have this problem, because it reads value from the registry directly in stead of depending on the getACP() function (which is the cause of the problem here).

Fixed in [77971ca3f2]. Note by design, registry is read only once for consistency with Windows where code page does not change in a running process even if registry changes.

Good point. Agree that looking up the registry is the preferred method.