Tcl Source Code

View Ticket
Login
Ticket UUID: c4f365470e1e9a4a713a19f0c2275b0a4620cce0
Title: Size modifiers j, q, z, t not implemented
Type: Bug Version: 9.0
Submitter: apnadkarni Created on: 2024-12-12 07:58:38
Subsystem: 18. Commands M-Z Assigned To: jan.nijtmans
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2024-12-13 10:20:11
Resolution: Fixed Closed By: jan.nijtmans
    Closed on: 2024-12-13 10:20:11
Description:

TIP 697 as well as the manpage scan.n document the size modifiers j, q, z, t. However, this does not seem to be actually implemented? Is that an oversight or intentionally omitted with docs not updated?

% scan 42 %ld
42
% scan 42 %zd
{}
% scan 42 %td
{}
% info patch
9.0.0
User Comments: jan.nijtmans added on 2024-12-13 10:20:11:

Fixed [6c1255aa6906a748|here]


jan.nijtmans added on 2024-12-12 14:16:25:

[deae6f2c251ba097|this] should work better. Good catch!


apnadkarni added on 2024-12-12 10:48:57:
> Those 4 are not useful for "scan", only for "format". 

BTW I do think they are useful for scan as well as since using h or l instead would require a pointerSize check first.

apnadkarni added on 2024-12-12 10:20:41:
Also, the TIP and the manpage say the `L` modifiers behaves like `ll` (consistent with format and different from 8.6). However, it appears it still behaves like `l` as in 8.6.

Given it has been TIP'ed and documented in the manpage, my preference is for the implementation to be fixed, particularly if as you say implementation is not too hard.

Your TIP-697 branch seems to already have the code implemented! And as far as I can tell was merged into main. So no idea what happened!

jan.nijtmans added on 2024-12-12 09:42:44:

Those 4 are not useful for "scan", only for "format".

I see now that in the TIP I mentioned to implement them for "scan" as well. Why???? I don't remember. Maybe I planned to do that, but never did.

So, should we add it (implementation is easy, actually)?