Tcl Source Code

View Ticket
Login
Ticket UUID: ba7491332a89da45d62f583e4ac848afcc89dd57
Title: Tcl_Panic from Itcl_SafeInit
Type: Bug Created on: 2021-09-21 08:33:23
Submitter: christian.nassau Assigned to: nobody
Subsystem: 81. Bundled Packages Severity: Severe
Priority: 5 Medium Last modified: 2021-09-21 08:33:23
Status: Open Closed by: nobody
Resolution: None Closed on:
Version: Itcl 4.2.1
Description:
The itcl initialization code has room for improvement.

The worst problem is that it is very easy to trigger a Tcl panic by trying to load the Itcl package: it suffices to create the itcl namespace beforehand. This code is also reached from Itcl_SafeInit so it can even be used to crash Tcl from a safe interpreter:

  /$ bin/tclsh8.6
  % namespace eval itcl { set some variable }
  variable
  % package req itcl
  Itcl: cannot create namespace: "::itcl"
  
  Aborted (core dumped)

A second point is that it seems unnecessarily difficult to get the location of the "itcl.tcl" initialization file right.  I believe the "itcl.tcl" should reside next to the library that needs it, so its location could (= should) be set in the pkgIndex.tcl file, using e.g.

  package ifneeded itcl 4.2.1 "[list set ::env(ITCL_LIBRARY) $dir];[list load [file join $dir "libitcl4.2.1.so"] Itcl]"