| Ticket UUID: | b5a02c53908e44ca5a21b30df67d3fb305904139 | ||
| Title: | Guard http::Connect against cleared socket info | ||
| Type: | Bug | Created on: | 2024-07-16 14:36:39 |
| Submitter: | oehhar | Assigned to: | nobody |
| Subsystem: | 29. http Package | Severity: | Minor |
| Priority: | 5 Medium | Last modified: | 2024-07-16 14:52:40 |
| Status: | Open | Closed by: | nobody |
| Resolution: | None | Closed on: | |
| Version: | core-8-6-branch | ||
| Description: | ||||
|
I get the following error trace with TWAPI 4.7.1 enabled TLS for the http package when I cancel (::http::cleanup) the request after the start:
--ErrorStack--
can't read "state(sock)": no such variable
while executing
"eof $state(sock)"
(procedure "http::Connect" line 7)
invoked from within
"http::Connect ::http::1 https {} /api/v2/devices/lookup.xml?di=EFRI310227552"
--Traceback--
INNER:loadArray1
CALL:http::Connect ::http::1 https {} /api/v2/devices/lookup.xml?di=EFRI310227552
CALL:::twapi::tls::_post_write_event_callback rc0
http package trace: ^A3 URL https://accessgudid.nlm.nih.gov/api/v2/devices/lookup.xml?di=EFRI310227552 - token ::http::3 Using rc2 for accessgudid.nlm.nih.gov:443 - token ::http::3 TWAPI setup:
http::register https 443 [concat {::twapi::tls_socket} -verifier TWAPIVerifier]
proc TWAPIVerifier {args} { return 1 }
HTTP Call:
set URL {https://accessgudid.nlm.nih.gov/api/v2/devices/lookup.xml?di=EFRI310227552}
set hReq [http::geturl $URL -timeout 60000 -command QueryContCall]
... some other commands ...
::http::cleanup $hReq
The TWAPI _post_write_event_callback has the following code: # NOTE: we do not check state here as we should generate an event # even in the CLOSED state - see Bug #206 chan postevent $chan write The http Connect function is as follows:
proc http::Connect {token proto phost srvurl} {
variable $token
upvar 0 $token state
set tk [namespace tail $token]
set err "due to unexpected EOF"
if {
[eof $state(sock)] ||
[set err [fconfigure $state(sock) -error]] ne ""
} {
I suppose, that http is called by TWAPI after a http cleanup. I think, it would be wise to check for $token existence at the beginning of Connect and just do nothing, if it does not exist. So, insert a line like:
if {![info exists state(sock)] } {return}
Does this feel like a good idea? Thank you and take care, Harald | ||||
