| Ticket UUID: | 8f5e7a2633ca1b92a878c039ba12675cbc8f7e69 | ||
| Title: | Tk build for 9.1 failing in safe-1.2 testcase | ||
| Type: | Bug | Created on: | 2025-11-13 10:27:13 |
| Submitter: | jan.nijtmans | Assigned to: | dkf |
| Subsystem: | 06. Time Measurement | Severity: | Severe |
| Priority: | 9 Immediate | Last modified: | 2026-03-11 09:44:31 |
| Status: | Pending | Closed by: | nobody |
| Resolution: | Fixed | Closed on: | |
| Version: | 9.1 | ||
| Description: | ||||
|
This is what's happening in Tk 9.1 right now. I suspect [a165eede1d22d847|this] commit is the coolpit. safe.test | ||||
| User Comments: | ||||
jan.nijtmans added on 2025-11-13 19:34:19:
Let's analyse the difference. Tcl 9.1 has the following unsafe commands, which Tcl 9.0 hasn't: clock, tcl:clock:add, tcl:clock:format, tcl:clock:scan, tcl:unsupported:disassemble, tcl:unsupported:getbytecode, tcl:unsupported:loadIcu, tcl:unsupported:representation. I think 'clock' is a mistake in this list. It should be usable in safe interpreters. The tcl:unsupported:* commands are correct, they should be considered unsafe in Tcl 9.0 too (backport??) So, what about tcl:clock:add, tcl:clock:format, tcl:clock:scan. @sebres, can you give advise? dkf added on 2025-11-14 13:07:23:
The NB: there's a comment by the
I think this bug might be the time to do that! The
dkf added on 2025-11-14 13:16:17:
Also, when it comes to ensembles they're all technically safe in themselves (their subcommands may not be).
The problem is working out what to do about existing code that uses a safe interpreter. dkf added on 2025-11-14 13:18:36:
The most irritating part of this is that I missed this because I don't habitually test Tk (as it's annoying on this machine). Sorry for the inconvenience. jan.nijtmans added on 2025-11-14 14:28:55:
> Sorry for the inconvenience No problem. Thanks for looking at it now. For the "unsupported" commands, easiest is to backport those parts to 9.0, since I agree with your analysis: They shouldn't be in the safe set. On the "clock"-related commands, maybe @sebres can provide help. He is the "clock" expert. dkf added on 2025-11-14 14:59:11:
With I've got a branch that does that (and fixes up the tests that fail because of it). We need to do some work about sorting out Tk though. The issue there looks like the test is fragile in the face of changes to the list of hidden subcommands and/or aliases managed by Tcl, things that shouldn't really matter to Safe Tk. Perhaps the test needs to be rewritten to filter out the baseline stuff from Tcl instead? dkf added on 2025-11-14 15:41:36:
The original strangeness was that On the Tk side, we should adjust the tests to not care what Tcl has defined in its safe base; Tk shouldn't be testing Tcl. dkf added on 2025-11-14 15:53:37:
Try 29ca32 for what I think is the fix on the Tk side. jan.nijtmans added on 2025-11-14 17:32:53:
> Try 29ca32 for what I think is the fix on the Tk side. Looks good to me. Thanks! +1 for core-9-0-branch and trunk (and 8.6, if you like, but not really necessary) jan.nijtmans added on 2025-11-27 21:07:38:
@dkf, you added the comment "Approach right, details not, source branch not right either" to the commit. What do you need to make progress? jan.nijtmans added on 2026-03-09 07:40:39:
ping jan.nijtmans added on 2026-03-11 09:44:31:
@dkf, what's the status of the "bug-8f5e7a2633" branch? I now re-enabled the testcase in Tk, the problem described in this ticket is gone. Thanks for your prototype doing this (which I finished)! However, keeping it "Pending", in case you want to work further on improving the "clock" initialization. | ||||
