Tcl Source Code

View Ticket
Login
Ticket UUID: 5294e6feca2e6a51dea496af8d1ceb1c30d86366
Title: minizip for TIP #430 broken
Type: Bug Created on: 2022-04-14 06:37:00
Submitter: jan.nijtmans Assigned to: hypnotoad
Subsystem: - New Builtin Commands Severity: Minor
Priority: 5 Medium Last modified: 2022-04-15 14:59:53
Status: Open Closed by: nobody
Resolution: Fixed Closed on:
Version:
Description:

TIP #430: Modifications to minizip.c: minizip has been modified to be able to handle recursive directory arguments.

Since zlib-1.2.11 is now replaced by zlib-1.2.12, this modification is now lost and needs to be redone, otherwize minizip is no longer sufficient to build Tcl with --enable-zipfs

User Comments:
jan.nijtmans added on 2022-04-14 06:39:15:

Assigning to Sean Woods.

I would recommend to contribute this change to the zlib developers, so it will will be included in zlib-1.2.13


jan.nijtmans added on 2022-04-14 14:06:49:

Proposed fix [27d3c50b994d0eca|here]


jan.nijtmans added on 2022-04-15 14:59:53:

Fixed [3481a747a0b97514|here]. However, it would be nice, not having to do this patching over-and-over again with every zlib release.

My recommendation would be to start using dirent for windows in stead of tinydir.h, to make this work with Visual Studio, then on UNIX or mingw-w64 it will work out-of-the-box.