Tcl Source Code

View Ticket
Login
Ticket UUID: 4f0b5767acbec00396762e6a3a6d10f59d2be778
Title: exec does not handle app execution aliases on Windows
Type: Bug Version:
Submitter: apnadkarni Created on: 2025-01-26 03:20:15
Subsystem: - New Builtin Commands Assigned To: nobody
Priority: 5 Medium Severity: Important
Status: Closed Last Modified: 2025-01-29 05:41:42
Resolution: Fixed Closed By: apnadkarni
    Closed on: 2025-01-29 05:41:42
Description:

Reported by Julian Noble on the chat:

JulianNoble ›	exec is not so nice on windows..  some modern apps seem to be installed as reparse points - which tcl doesn't seem to handle
[22:08]	JulianNoble ›	winget being a notable example

Proposed fix in bug-4f0b5767ac

User Comments: apnadkarni added on 2025-01-29 05:41:42:
It could indeed be so :-) Fixed now. Tx @chw

chw added on 2025-01-29 04:29:32:
Could it be that check-in [bc9227d33f] and friends leak
a HANDLE for the FILE_ATTRIBUTE_REPARSE_POINT case?

apnadkarni added on 2025-01-28 05:00:30:
Thanks, Harald.

@sebres, saw your comment on the chat. However, the MSDN docs say FILE_FLAG_OPEN_REPARSE_POINT is ignored for non-reparse points so I don't think checking attr is really necessary. I have no objection if you want to add the check but I don't want to make a change and go through another github CI cycle as I don't believe that check is required.

Merged in [b0d73da3df].

oehhar added on 2025-01-27 18:12:41:

Great work! Please merge. Thanks, Harald


apnadkarni added on 2025-01-27 17:05:35:
Forgot to note - passed github actions CI.

apnadkarni added on 2025-01-27 17:05:00:
Awaiting approval to merge into trunk.