Tcl Source Code

View Ticket
Login
Ticket UUID: 495120
Title: 'make dist' adds line: tools/tcl.wse.in
Type: Bug Created on: 2001-12-19 17:33:31
Submitter: dgp Assigned to: davygrvy
Subsystem: 53. Configuration and Build Tools Severity:
Priority: 5 Medium Last modified: 2001-12-20 09:18:50
Status: Closed Closed by: dgp
Resolution: Fixed Closed on: 2001-12-20 02:18:50
Version: obsolete: 8.4a4
Description:
Every run of 'make dist' appends another line
to the file tools/tcl.wse.in.

This is probably a bug in tools/eolFix.tcl.
User Comments:
mdejong added on 2001-12-20 02:53:47:
Logged In: YES 
user_id=90858

Reassigning to eolFix.tcl author.

davygrvy added on 2001-12-20 08:41:47:
Logged In: YES 
user_id=7549

tcl.wse.in had corrupted <eol> in CVS.  This resulted in 
extra lines being added.

I scanned the whole repository just to be sure this was the 
only one left.  No extra problems found.

dgp added on 2001-12-20 08:50:45:
Logged In: YES 
user_id=80530

Sorry, that did not fix the problem I see on Linux/Alpha:

$ cvs -n up
$ cd unix
$ ./configure
$ make dist
$ cd ..
$ cvs -n up
M tools/tcl.wse.in

Hmmm, there is a difference.  Before the change
to tools/tcl.wse.in was the addition of an empty line.
Now the change is on all line, presumably a change of
the eol.  Should I recommit the changed file?

dgp added on 2001-12-20 08:56:19:
Logged In: YES 
user_id=80530

For that matter, why is 'make dist' overwriting my
working files at all?  It can write, re-write, transform
the files it's placing in the distribution as appropriate,
but shouldn't it leave my original files alone?

dgp added on 2001-12-20 09:15:12:
Logged In: YES 
user_id=80530

Yeah, I think that's the real bug I'm seeing.
Line 1240 of unix/Makefile.in has TOP_DIR
where it should have DISTDIR.

And if davygrvy got another bug fixed in the
process, that's cool too

dgp added on 2001-12-20 09:18:50:
Logged In: YES 
user_id=80530

commited fix to unix/Makefile.in.