In tclExecute.c, the implementation of the
INST_STR_MATCH instruction pretty apparently
wants to be the same function as the internal
routine TclStringMatchObj().
However, the code is not the same. It appears
the tclExecute.c code is correct, since the
TclStringMatchObj() routine in tclUtil.c is written
so that a whole stanza is unreachable.
This feels so wrong to have this code duplication.
Is it truly unacceptable in some way to just have
tclExecute.c call TclStringMatchObj() when it
needs it? If so, might we at least use a common
macro expansion in both places?
See also
http://core.tcl.tk/tcl/tktview?name=85b87a7570
|