Tcl Source Code

View Ticket
Login
Ticket UUID: 15845d9fd8accdf193b85d54498bfa48dcd275a3
Title: unix/tcl.m4: implicit declaration of exit() in timezone variable checks
Type: Bug Version: 8.6.12
Submitter: chrstphrchvz Created on: 2021-11-06 04:18:58
Subsystem: 53. Configuration and Build Tools Assigned To: jan.nijtmans
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2021-11-07 21:44:45
Resolution: Fixed Closed By: jan.nijtmans
    Closed on: 2021-11-07 21:44:45
Description: (text/x-fossil-wiki)
The checks for <tt>long</tt> timezone variable and <tt>time_t</tt> timezone variable may both erroneously fail due to compilers which by default use <tt>-Werror=implicit-function-declaration</tt> (e.g. Xcode 12 and newer on macOS, as required by ARM64 ABI), because the <tt>exit()</tt> function is used without <tt>#include &lt;stdlib.h&gt;</tt>.

To correct this: in unix/tcl.m4, either stdlib.h should be included for these tests, or <tt>return 0;</tt> used instead of <tt>exit (0);</tt>. Then unix/configure should then be regenerated to pick up the changes.
User Comments: jan.nijtmans added on 2021-11-07 21:44:45: (text/x-fossil-wiki)
Fixed in all branches (8.6 and up) now. Thanks for the report and for the suggested fix!