D 2024-06-19T12:02:42.294
J assignee nobody
J closer nobody
J cmimetype text/x-fossil-wiki
J comment In\s[eb627bda27|this]\scommit,\san\sextensive\srewrite\swas\sdone\son\sthe\schan.n\smanpage.\r\n\r\nThe\smost\simportant\sproblem\sin\sthis\scommit\sis\sthat\s"channelId"\swas\srenamed\sto\s"channelName".\sHowever,\s"channelName"\sisn't\sused\sin\sany\sother\sman-page,\s"channelId"\sis.\sSo,\sif\sthis\sis\sa\sgood\schange,\sit\sshould\sbe\sdone\sin\sall\srelated\sman-pages\stoo.\sOtherwise\sconsistancy\sis\slost.\r\n\r\nMy\ssecond\scritisism\sis\sthat\sdoc-changes\swhich\sare\snot\smade\sdue\sto\sa\snew\sfeature\sshould\shave\sa\sgood\scommit\smessage,\sdescribing\swhy\sthe\scommit\swas\sdone.\sFor\sexample:\s[d664748a86b7b8b5|this]\sis\sa\sgood\sexample.\s"Rewrite\sof\sdocumentation\sfor\s[chan]"\sis\snot\sa\sgood\scommit\smessage.\r\n\r\nThird,\swhy\swas\sthe\srewrite\snot\sbackported\sto\s8.6?\sSince\s8.6\sis\sthe\scurrent\srelease,\sdocumentation\simprovements\sare\svalueable\sthere\stoo.\r\n\r\nHowever,\sI\sagree\sthat\s"channelId"\sis\snot\sthe\sbest\sname\swhat\swe\sare\srefering\stoo.\s\sIt\ssuggests\sforms\slike\s"file1234"\sor\s"sock4321",\swhich\s-\sindeed\s-\slook\slike\sid's.\sBut\s"stderr"\sand\s"stdout"\slook\smore\slike\schannel\snames.\sIn\sTcl\sscripts,\schannels\scan\shave\sboth\sforms,\sthere\sis\sno\sneed\sto\sdistinguis\sbetwen\sthem.\sSo,\sI\spropose\sto\sresolve\sthis\spossible\sconfusion\sby\susing\ssimply\s"channel"\severywhere.\r\n\r\nSince\sin\sTcl,\s'everything\sis\sa\sstring',\s"channel"\sis\san\sappropriate\sname\sfor\swhat\swe\sare\sdealing\swith\shere.\r\n\r\nSee:\s[https://core.tcl-lang.org/tcl/timeline?r=no-channelid|here]\sfor\sthe\simplementation\sof\sthis\sproposed\schange.
J foundin 8.7
J is_private 0
J login jan.nijtmans
J priority 5\sMedium
J private_contact 0c50e5320704d174412e57b873d8932de15303e0
J resolution None
J severity Minor
J status Open
J submitter jan.nijtmans
J subsystem -\sNew\sBuiltin\sCommands
J title Reviewing\schan.n\schanges
J type Bug
K 7be97a685975ec271a02518a0d88c6bc121f8df6
U jan.nijtmans
Z 669288ad115ab5ed9fb69192785781c8