Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
| Comment: | Bug [40b1814b93] - Proposed fix for Winsock use-after-frees |
|---|---|
| Downloads: | Tarball | ZIP archive |
| Timelines: | family | ancestors | descendants | both | bug-40b1814b93 |
| Files: | files | file ages | folders |
| SHA3-256: |
bbb565eca787dfadbf621020d31ae27a |
| User & Date: | apnadkarni 2025-06-14 05:31:49.533 |
Context
|
2025-06-14
| ||
| 11:44 | Merge core-9-0-branch check-in: d4999cbc1a user: apnadkarni tags: bug-40b1814b93 | |
| 05:31 | Bug [40b1814b93] - Proposed fix for Winsock use-after-frees check-in: bbb565eca7 user: apnadkarni tags: bug-40b1814b93 | |
| 03:25 | Add testhandlecount command to check Windows handle leaks check-in: ad954921d6 user: apnadkarni tags: core-9-0-branch | |
Changes
Changes to win/tclWinSock.c.
| ︙ | ︙ | |||
542 543 544 545 546 547 548 | PostMessageW(tsdPtr->hwnd, SOCKET_TERMINATE, 0, 0); /* * Wait for the thread to exit. This ensures that we are * completely cleaned up before we leave this function. */ | | | 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 |
PostMessageW(tsdPtr->hwnd, SOCKET_TERMINATE, 0, 0);
/*
* Wait for the thread to exit. This ensures that we are
* completely cleaned up before we leave this function.
*/
WaitForSingleObject(tsdPtr->socketThread, INFINITE);
tsdPtr->hwnd = NULL;
}
CloseHandle(tsdPtr->socketThread);
tsdPtr->socketThread = NULL;
}
if (tsdPtr->readyEvent != NULL) {
CloseHandle(tsdPtr->readyEvent);
|
| ︙ | ︙ | |||
2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 |
* place to look for bugs.
*/
if (bind(sock, addrPtr->ai_addr,
addrPtr->ai_addrlen) == SOCKET_ERROR) {
Tcl_WinConvertError((DWORD) WSAGetLastError());
closesocket(sock);
continue;
}
if (port == 0 && chosenport == 0) {
address sockname;
socklen_t namelen = sizeof(sockname);
/*
| > | 2217 2218 2219 2220 2221 2222 2223 2224 2225 2226 2227 2228 2229 2230 2231 |
* place to look for bugs.
*/
if (bind(sock, addrPtr->ai_addr,
addrPtr->ai_addrlen) == SOCKET_ERROR) {
Tcl_WinConvertError((DWORD) WSAGetLastError());
closesocket(sock);
sock = INVALID_SOCKET; /* Bug [40b1814b93] */
continue;
}
if (port == 0 && chosenport == 0) {
address sockname;
socklen_t namelen = sizeof(sockname);
/*
|
| ︙ | ︙ | |||
2245 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 |
if (backlog < 0) {
backlog = SOMAXCONN;
}
if (listen(sock, backlog) == SOCKET_ERROR) {
Tcl_WinConvertError((DWORD) WSAGetLastError());
closesocket(sock);
continue;
}
if (statePtr == NULL) {
/*
* Add this socket to the global list of sockets.
*/
| > | 2246 2247 2248 2249 2250 2251 2252 2253 2254 2255 2256 2257 2258 2259 2260 |
if (backlog < 0) {
backlog = SOMAXCONN;
}
if (listen(sock, backlog) == SOCKET_ERROR) {
Tcl_WinConvertError((DWORD) WSAGetLastError());
closesocket(sock);
sock = INVALID_SOCKET; /* Bug [40b1814b93] */
continue;
}
if (statePtr == NULL) {
/*
* Add this socket to the global list of sockets.
*/
|
| ︙ | ︙ |