Tcl Source Code

Ticket Change Details
Login
Overview

Artifact ID: b0098ba5990dd4d6f5e6578a9f87d88ddb7ea226
Ticket: fb2208172c671f29d60e9ac928d9ded45d01d8b8
tclIndex varies across builds from auto_mkindex
User & Date: bmwiedemann 2017-07-17 06:51:29
Changes

  1. assignee changed to: "nobody"
  2. closer changed to: "nobody"
  3. cmimetype changed to: "text/plain"
  4. comment changed to:
    might be related to https://core.tcl.tk/tcl/tktview/218239ffffffffffffff
    
    The exmh package in openSUSE does not build reproducibly
    because the tclIndex files varies for each build.
    
    Here is a simple patch to fix it:
    
    From: "Bernhard M. Wiedemann" <[email protected]>
    Date: Mon, 17 Jul 2017 08:32:17 +0200
    Subject: [PATCH] Sort glob used in auto_mkindex
    
    necessary because glob manual says
    No particular order is guaranteed in the list,
    so if a sorted list is required the caller should use lsort.
    
    This was causing the exmh package to not build reproducibly.
    See https://reproducible-builds.org/ for why this matters.
    ---
     library/auto.tcl | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/library/auto.tcl b/library/auto.tcl
    index 97ea8af..568beb0 100644
    --- a/library/auto.tcl
    +++ b/library/auto.tcl
    @@ -203,7 +203,7 @@ proc auto_mkindex {dir args} {
         } 
    
         auto_mkindex_parser::init
    -    foreach file [glob -- {*}$args] {
    +    foreach file [lsort [glob -- {*}$args]] {
            try {
                append index [auto_mkindex_parser::mkindex $file]
            } on error {msg opts} {
    -- 
    2.12.3
    
  5. foundin changed to: "8.6.6"
  6. is_private changed to: "0"
  7. login: "bmwiedemann"
  8. priority changed to: "5 Medium"
  9. private_contact changed to: "77f471323bffeae13597270e52be6ffde7a23680"
  10. resolution changed to: "None"
  11. severity changed to: "Minor"
  12. status changed to: "Open"
  13. submitter changed to: "bmwiedemann"
  14. subsystem changed to: "69. Other"
  15. title changed to: "tclIndex varies across builds from auto_mkindex"
  16. type changed to: "Bug"