Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | tclWinPipe.c:3427:12: warning: unused parameter ‘wakeEvent’ [-Wunused-parameter] |
---|---|
Downloads: | Tarball | ZIP archive |
Timelines: | family | ancestors | descendants | both | core-9-0-branch |
Files: | files | file ages | folders |
SHA3-256: |
aeabc7bc4913d7a618283c9ea377b58a |
User & Date: | jan.nijtmans 2025-06-26 09:55:11.005 |
Context
2025-06-26
| ||
11:14 | Make everthing compile (again) and run with a C++ compiler. check-in: aa010c0cda user: jan.nijtmans tags: core-9-0-branch | |
09:56 | Merge 9.0 check-in: 52ff13f312 user: jan.nijtmans tags: trunk, main | |
09:55 | tclWinPipe.c:3427:12: warning: unused parameter ‘wakeEvent’ [-Wunused-parameter] check-in: aeabc7bc49 user: jan.nijtmans tags: core-9-0-branch | |
2025-06-25
| ||
16:23 | Fix [7c2716733a] - use after free on Windows pipe handles check-in: a9351d85f3 user: apnadkarni tags: core-9-0-branch | |
Changes
Changes to win/tclWinInt.h.
︙ | ︙ | |||
118 119 120 121 122 123 124 | TclPipeThreadIsAlive( TclPipeThreadInfo **pipeTIPtr) { TclPipeThreadInfo *pipeTI = *pipeTIPtr; return (pipeTI && pipeTI->state != PTI_STATE_DOWN); }; | | < | 118 119 120 121 122 123 124 125 126 127 128 129 130 | TclPipeThreadIsAlive( TclPipeThreadInfo **pipeTIPtr) { TclPipeThreadInfo *pipeTI = *pipeTIPtr; return (pipeTI && pipeTI->state != PTI_STATE_DOWN); }; MODULE_SCOPE int TclPipeThreadStopSignal(TclPipeThreadInfo **pipeTIPtr); MODULE_SCOPE void TclPipeThreadStop(TclPipeThreadInfo **pipeTIPtr, HANDLE hThread); MODULE_SCOPE void TclPipeThreadExit(TclPipeThreadInfo **pipeTIPtr); #endif /* _TCLWININT */ |
Changes to win/tclWinPipe.c.
︙ | ︙ | |||
2048 2049 2050 2051 2052 2053 2054 | * terminate the thread and close the handles. If the channel is * nonblocking or may block during exit, bail out since the worker * thread is not interruptible and we want TIP#398-fast-exit. */ if ((pipePtr->flags & PIPE_ASYNC) && inExit) { /* give it a chance to leave honorably */ | | | 2048 2049 2050 2051 2052 2053 2054 2055 2056 2057 2058 2059 2060 2061 2062 | * terminate the thread and close the handles. If the channel is * nonblocking or may block during exit, bail out since the worker * thread is not interruptible and we want TIP#398-fast-exit. */ if ((pipePtr->flags & PIPE_ASYNC) && inExit) { /* give it a chance to leave honorably */ TclPipeThreadStopSignal(&pipePtr->writeTI); if (WaitForSingleObject(pipePtr->writable, 20) == WAIT_TIMEOUT) { return EWOULDBLOCK; } } else { |
︙ | ︙ | |||
3419 3420 3421 3422 3423 3424 3425 | * 1 if signaled (or pipe-thread is down), 0 if pipe thread still working. * *---------------------------------------------------------------------- */ int TclPipeThreadStopSignal( | | < | 3419 3420 3421 3422 3423 3424 3425 3426 3427 3428 3429 3430 3431 3432 3433 | * 1 if signaled (or pipe-thread is down), 0 if pipe thread still working. * *---------------------------------------------------------------------- */ int TclPipeThreadStopSignal( TclPipeThreadInfo **pipeTIPtr) { TclPipeThreadInfo *pipeTI = *pipeTIPtr; HANDLE evControl; int state; if (!pipeTI) { return 1; |
︙ | ︙ |