Many hyperlinks are disabled.
Use anonymous login
to enable hyperlinks.
Overview
Comment: | Fix for issue [a8579d906a28], "argument with no name". |
---|---|
Downloads: | Tarball | ZIP archive | SQL archive |
Timelines: | family | ancestors | descendants | both | core-8-6-branch |
Files: | files | file ages | folders |
SHA3-256: |
75a9777184741e059cb42997f84ba98b |
User & Date: | pooryorick 2021-10-08 19:42:22.046 |
Original Comment: | Fix for issue a8579d906a28, "argument with no name". |
References
2021-10-08
| ||
19:51 | • Ticket [a8579d906a] 'argument with no name' calling proc with args built in different frame status still Open with 4 other changes artifact: 91c0e89b2c user: pooryorick | |
Context
2021-10-11
| ||
13:54 | Better solution, in stead of 6ffcea9b: Handle 6... check-in: 89c20907fe user: jan.nijtmans tags: core-8-6-branch | |
2021-10-08
| ||
19:42 | Fix for issue [a8579d906a28], "argument with no name". check-in: 75a9777184 user: pooryorick tags: core-8-6-branch | |
07:04 | merge-mark check-in: 628a86de6d user: jan.nijtmans tags: core-8-6-branch | |
Changes
Changes to generic/tclProc.c.
︙ | ︙ | |||
493 494 495 496 497 498 499 | Tcl_AppendObjToObj(errorObj, argArray[i]); Tcl_AppendToObj(errorObj, "\"", -1); Tcl_SetObjResult(interp, errorObj); Tcl_SetErrorCode(interp, "TCL", "OPERATION", "PROC", "FORMALARGUMENTFORMAT", NULL); goto procError; } | | | 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 | Tcl_AppendObjToObj(errorObj, argArray[i]); Tcl_AppendToObj(errorObj, "\"", -1); Tcl_SetObjResult(interp, errorObj); Tcl_SetErrorCode(interp, "TCL", "OPERATION", "PROC", "FORMALARGUMENTFORMAT", NULL); goto procError; } if ((fieldCount == 0) || (Tcl_GetCharLength(fieldValues[0]) == 0)) { Tcl_SetObjResult(interp, Tcl_NewStringObj( "argument with no name", -1)); Tcl_SetErrorCode(interp, "TCL", "OPERATION", "PROC", "FORMALARGUMENTFORMAT", NULL); goto procError; } |
︙ | ︙ |
Changes to tests/proc.test.
︙ | ︙ | |||
320 321 322 323 324 325 326 327 328 329 330 331 332 333 | } -cleanup { rename getbytes {} unset -nocomplain end i tmp leakedBytes } -result 0 test proc-4.9 {[39fed4dae5] Valid Tcl_PkgPresent return} procbodytest { procbodytest::check } 1 test proc-5.1 {Bytecompiling noop; test for correct argument substitution} -body { proc p args {} ; # this will be bytecompiled into t proc t {} { set res {} set a 0 set b 0 | > > > > > > > > > | 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 | } -cleanup { rename getbytes {} unset -nocomplain end i tmp leakedBytes } -result 0 test proc-4.9 {[39fed4dae5] Valid Tcl_PkgPresent return} procbodytest { procbodytest::check } 1 test proc-4.10 { TclCreateProc, issue a8579d906a28, argument with no name } -body { catch { proc p1 [list [list [expr {1 + 2}] default]] {} } } -cleanup { catch {rename p1 {}} } -result 0 test proc-5.1 {Bytecompiling noop; test for correct argument substitution} -body { proc p args {} ; # this will be bytecompiled into t proc t {} { set res {} set a 0 set b 0 |
︙ | ︙ |