Tcl Source Code

Check-in [48925f56c8]
Login

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

Overview
Comment:
* generic/tclStringObj.c: AppendUnicodeToUnicodeRep failed to set stringPtr->allocated to 0, leading to crashes.
Downloads: Tarball | ZIP archive
Timelines: family | ancestors | descendants | both | core-8-5-7 | core-8-5-branch
Files: files | file ages | folders
SHA1: 48925f56c8299346f7b74baf1ceacbee3db7f653
User & Date: dgp 2009-04-15 19:07:04.000
Context
2009-04-24
15:15
Don't chmod/exec installManPage. [Patch 2769530] check-in: 18ed5a745a user: stwo tags: core-8-5-branch
2009-04-15
19:07
* generic/tclStringObj.c: AppendUnicodeToUnicodeRep failed to set stringPtr->a...
check-in: 48925f56c8 user: dgp tags: core-8-5-7, core-8-5-branch
13:42
* changes: Update for 8.5.7 release.
check-in: cb0d65dd5f user: dgp tags: core-8-5-branch
Changes
Unified Diff Ignore Whitespace Patch
Changes to ChangeLog.
1
2
3



4
5
6
7
8
9
10
2009-04-15  Don Porter  <[email protected]>

	*** 8.5.7 TAGGED FOR RELEASE ***




	* changes:	Update for 8.5.7 release.

2009-04-14  Stuart Cassoff  <[email protected]>

	* unix/tcl.m4:	Removed -Wno-implicit-int from CFLAGS_WARNING.




>
>
>







1
2
3
4
5
6
7
8
9
10
11
12
13
2009-04-15  Don Porter  <[email protected]>

	*** 8.5.7 TAGGED FOR RELEASE ***

	* generic/tclStringObj.c:	AppendUnicodeToUnicodeRep failed
	to set stringPtr->allocated to 0, leading to crashes.

	* changes:	Update for 8.5.7 release.

2009-04-14  Stuart Cassoff  <[email protected]>

	* unix/tcl.m4:	Removed -Wno-implicit-int from CFLAGS_WARNING.

Changes to generic/tclStringObj.c.
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
 *
 * Copyright (c) 1995-1997 Sun Microsystems, Inc.
 * Copyright (c) 1999 by Scriptics Corporation.
 *
 * See the file "license.terms" for information on usage and redistribution of
 * this file, and for a DISCLAIMER OF ALL WARRANTIES.
 *
 * RCS: @(#) $Id: tclStringObj.c,v 1.70.2.11 2009/04/10 22:14:29 patthoyts Exp $ */

#include "tclInt.h"
#include "tommath.h"

/*
 * Prototypes for functions defined later in this file:
 */







|







29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
 *
 * Copyright (c) 1995-1997 Sun Microsystems, Inc.
 * Copyright (c) 1999 by Scriptics Corporation.
 *
 * See the file "license.terms" for information on usage and redistribution of
 * this file, and for a DISCLAIMER OF ALL WARRANTIES.
 *
 * RCS: @(#) $Id: tclStringObj.c,v 1.70.2.12 2009/04/15 19:07:04 dgp Exp $ */

#include "tclInt.h"
#include "tommath.h"

/*
 * Prototypes for functions defined later in this file:
 */
1406
1407
1408
1409
1410
1411
1412

1413
1414
1415
1416
1417
1418
1419
     * trailing null.
     */

    memcpy(stringPtr->unicode + stringPtr->numChars, unicode,
	    appendNumChars * sizeof(Tcl_UniChar));
    stringPtr->unicode[numChars] = 0;
    stringPtr->numChars = numChars;


    Tcl_InvalidateStringRep(objPtr);
}

/*
 *----------------------------------------------------------------------
 *







>







1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
     * trailing null.
     */

    memcpy(stringPtr->unicode + stringPtr->numChars, unicode,
	    appendNumChars * sizeof(Tcl_UniChar));
    stringPtr->unicode[numChars] = 0;
    stringPtr->numChars = numChars;
    stringPtr->allocated = 0;

    Tcl_InvalidateStringRep(objPtr);
}

/*
 *----------------------------------------------------------------------
 *