Tcl Source Code

View Ticket
Login
2026-10-22
17:19 • Ticket [3b00b2198d] async test suite calls are missing cleanup status still ... artifact: 9a1e7402bc user: serhiy.storchaka
2026-10-21
10:58 • Ticket [3b00b2198d]: 3 changes artifact: c527e79fc6 user: serhiy.storchaka
10:58
Fix [3b00b2198d]: async test suite calls are missing cleanup check-in: 6b2fff63e6 user: serhiy.storchaka tags: core-8-6-branch
10:58
Fix [3b00b2198d]: async test suite calls are missing cleanup check-in: ff7935f994 user: serhiy.storchaka tags: core-9-0-branch
10:56 • Closed ticket [3b00b2198d]: async test suite calls are missing cleanup plus ... artifact: 6d65fcf68c user: serhiy.storchaka
10:56
Fix [3b00b2198d]: async test suite calls are missing cleanup check-in: 0f5fdaa945 user: serhiy.storchaka tags: trunk, main
10:48 • Ticket [3b00b2198d] async test suite calls are missing cleanup status still ... artifact: e5f55e30fc user: jan.nijtmans
2026-10-20
13:39 • Ticket [3b00b2198d]: 4 changes artifact: acfe173328 user: serhiy.storchaka
13:38
Fix [3b00b2198d]: interp-36.7 waits for the bgerror handler instead of a fixed 10 ms timer, which lo... closed check-in: a81652d24d user: serhiy.storchaka tags: interp-36.7-race
2021-07-20
09:28 • New ticket [3b00b2198d] async test suite calls are missing cleanup. artifact: 915212571a user: anonymous

Ticket UUID: 3b00b2198d3a901ff4ec002ff705a0162f7bf202
Title: async test suite calls are missing cleanup
Type: Bug Created on: 2021-07-20 09:28:34
Submitter: anonymous Assigned to: jan.nijtmans
Subsystem: 34. tcltest Package Severity: Minor
Priority: 5 Medium Last modified: 2026-10-22 17:19:32
Status: Closed Closed by: serhiy.storchaka
Resolution: Fixed Closed on: 2026-10-21 10:56:31
Version: 8.6.18, 9.0.5, 9.1.0
Description:
A number of the async tests that use vwait/after are missing cleanup or have race conditions.

For example, interp-36.7 will fail if the host system is under load as the 'foo' message doesn't get output correctly.  Discussion on the #tcl IRC channel led us to incorporating this patch which seems to have made the test more reliable:

http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-devtools/tcltk/tcl/interp.patch

That patch should probably be merged into tcl.

Also, the same problems appear to exists for other tests, for example we just had a failure in socket:

==== socket-14.12 [socket -async] background progress triggered by [fconfigure -error] FAILED
==== Contents of test case:

    set s [socket -async localhost [randport]]
    for {set i 0} {$i < 50} {incr i} {
        set x [fconfigure $s -error]
        if {$x != ""} break
        after 200
    }
    set x

---- Result was:

---- Result should have been (exact matching):
connection refused
User Comments:
serhiy.storchaka added on 2026-10-20 13:39:16:

interp-36.7 has a race: if the process is held up for more than 10 ms, after 0 error foo and after 10 set done fire in the same timer pass and vwait returns before the bgerror handler has run. Reproduced on main and 8.6 by adding a 20 ms sleep before the vwait (result "untouched").

Proposed fix in branch [a81652d24d|interp-36.7-race]: wait for the variable the handler sets, with a 10 s timeout. It passes with the added sleep and still fails without child bgerror handler.

socket-14.12 doesn't fail here (randport takes a fresh port from socket -server {} 0 since 2017). A separate ticket with details would help if it still happens.


jan.nijtmans added on 2026-10-21 10:48:26:

+1

Test-case only fixes/improvements don't need an entry in the changelog.


serhiy.storchaka added on 2026-10-21 10:58:58:

Merged into trunk [0f5fdaa945], backported to core-9-0-branch [ff7935f994] and core-8-6-branch [6b2fff63e6].