Tcl Source Code

View Ticket
10:15 Closed ticket [0aa7638534]: .gitignore ignores library/tcltest.tcl plus 7 other changes artifact: c98b8449c2 user: jan.nijtmans
Fix [0aa7638534]: .gitignore ignores library/tcltest.tcl check-in: 88ba977d2d user: jan.nijtmans tags: core-8-6-branch
Fix [0aa7638534]: .gitignore ignores library/tcltest.tcl check-in: 0125d1636b user: jan.nijtmans tags: core-8-5-branch
19:19 Ticket [0aa7638534] .gitignore ignores library/tcltest.tcl status still Open with 3 other changes artifact: 41fc656632 user: fvogel
18:17 New ticket [0aa7638534]. artifact: 308635708b user: chrstphrchvz

Ticket UUID: 0aa76385340091e4370bed90f5798e0d6e734800
Title: .gitignore ignores library/tcltest.tcl
Type: Bug Version: core-8-6-branch
Submitter: chrstphrchvz Created on: 2022-08-29 18:17:11
Subsystem: None Assigned To: jan.nijtmans
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2022-08-31 10:15:22
Resolution: Fixed Closed By: jan.nijtmans
    Closed on: 2022-08-31 10:15:22

.gitignore contains */tcltest* which causes library/tcltest.tcl to be ignored, which I believe is erroneous.

User Comments: jan.nijtmans added on 2022-08-31 10:15:22:

The intention of this rule was that the tcltest executable (win/tcltest.exe or unix/tcltest) cannot be committed by accident. The '*' in the rule would match the ".exe" on Windows. But ... there is already a seperate ".exe" rule, so the easiest fix is to remove the '*' from the rules. Then it won't match "tcltest.tcl" any more, which was - indeed - unintentional.

Fixed now in all branches.

Thanks for the report!

fvogel added on 2022-08-29 19:19:06:

Ditto in .fossil-settings/ignore-glob

This is the case the Tcl (*/tcltest*) and Tk (*/tktest*) at least. This indeed sounds like an error. I think this could just be removed. Unless I'm missing a good reason for the opposite?(if so the glob should be refined to include what is wanted and exclude what is not).