Bounty program for improvements to Tcl and certain Tcl packages.

Many hyperlinks are disabled.
Use anonymous login to enable hyperlinks.

50 check-ins occurring around 3637c3fa4086ddb9.

/tmp/f check-in: 659defba32 user: eee tags: expect_5_44_1_15, trunk
Undoing all changes made by me during ANSIfication attempt, and reverting to tag 'expect_5_44_1_15'. Further ANSIfication will be pursued on a branch. check-in: 5bf9e2c817 user: eee tags: trunk
Change to how <fcntl.h> is included. check-in: ce28cdd7c6 user: eee tags: trunk
ANSIfication changes. check-in: 306b3e4ca4 user: eee tags: trunk
ansification check-in: e385cc794f user: eee tags: trunk
ANSIfication check-in: 25ef313d5b user: eee tags: trunk
more ANSIfications check-in: db3d6db8b3 user: eee tags: trunk
More ANSIfication check-in: ae3b8cde02 user: eee tags: trunk
ANSIfication changes check-in: e785babaae user: eee tags: trunk
ANSIfication changes. check-in: 7261e72970 user: eee tags: trunk
WHITESPACE CHANGES ONLY. I removed a number of form-feed characters that had been littered about the source code. check-in: 427e90617d user: eee tags: trunk
Converting function declarations and definitions from K&R style to ISO C style, along with occasional related comment changes. check-in: 85282a664c user: eee tags: trunk
Fixed typo check-in: 968e0015cb user: eee tags: trunk
Added bug reference for the last commit. check-in: 39d185f825 user: andreas_kupries tags: trunk
See last ChangeLog entry: Ditto for the same type of bug when emitting error 'usage: -ignore unknown signal name'. The remainder of the exp_error calls are ok however. check-in: 406ad660a8 user: andreas_kupries tags: trunk
* exp_command.c (Exp_SpawnObjCmd): [Expect SF Bug 2891422]. Fixed error message when the command to spawn could not be executed. Tried to use a Tcl_Obj* as argument for a %s. Replaced with the correct char* variable. Thanks to Elchonon Edelson <[email protected]> for the report. * configure.in: Bumped version to * configure: Regen'd, autoconf 2.59. check-in: 7879625236 user: andreas_kupries tags: trunk
* exp_clib.c (TclRegComp): Fixed memory leak reported by <[email protected]> in [Expect SF Bug 2814263]. check-in: a6f01a3232 user: andreas_kupries tags: trunk
* pty_unicos.c (pty_stty): Fixed missing double-quotes for sprint formatting strings. Thanks to <[email protected]> for the report, i.e. [Expect SF Bug 2809496]. check-in: 57500f9a63 user: andreas_kupries tags: trunk
* exp_command.c (Exp_LogFileObjCmd): Fix argument parsing logic error in the log_file command breaking the use of options -open and -leaveopen. Applied patch supplied by Andy Belsey <[email protected]>. With thanks for both the analysis of the problem and the patch. * configure.in: Bumped version to * configure: Regen'd, autoconf 2.59. check-in: 416aa515e9 user: andreas_kupries tags: trunk
* exp_tty.c (Exp_SttyCmd, Exp_SystemCmd): Applied patch by Reinhard Max ([email protected]) fixing buffer-overflows in the 'stty' command due to an off-by-one error in the buffer size. See the bugs https://bugzilla.novell.com/show_bug.cgi?id=506873 and https://bugzilla.novell.com/show_bug.cgi?id=501291 * configure.in: Bumped version to * configure: Regen'd, autoconf 2.59. check-in: 20c9e7fc08 user: andreas_kupries tags: trunk
* retoglob.c: Accepted the patch by Mike Cumings <[email protected]> fixing [Expect SF Bug 13179]. The updated code checks a (?...) sequence that it contains only ARE options before processing it as such. This prevents the misinterpretation of non-capturing paren groups as ARe options with subsequent segmentation fault. * configure.in: Bumped version to * configure: Regen'd, autoconf 2.59. check-in: 07c021bf15 user: andreas_kupries tags: trunk
More fixes in that area. Use second index for destination array, avoid complex index calculations to derive from index in objv. check-in: 97a0cd25df user: andreas_kupries tags: trunk
Fixed indexing error left over from command correction. Was still using overlay arguments for the execvp'd command. check-in: bf0018fbdc user: andreas_kupries tags: trunk
* configure.in: Bumped version to * configure: Regen'd, autoconf 2.59. * exp_command.c (Exp_OverlayObjCmd): Fixed [Expect SF Bug 2127456] reported by <[email protected]>, with thanks. Changed retrieval of command from objv[0] (== 'overlay' itself), to objv[i] containing the actual user command. * expect.c (string_case_first, string_first, eval_case_string): Applied patch supplied by Andy Belsey <[email protected]> fixing the seg.fault in 'expect -exact'. With thanks for both the analysis of the problem and the patch. See also [Expect SF Bug 2114547]. check-in: d432545301 user: andreas_kupries tags: trunk
* exp_trap.c (tophalf): Fixed inverted condition setting the interpreter used for trap handling to NULL, causing a crash when trying to handle ^C. This fixes [SF Bug 1757471] reported by Matthias Kraft <[email protected]>. * configure.in: Bumped version to * configure: Regen'd, autoconf 2.59. check-in: 3637c3fa40 user: andreas_kupries tags: trunk
improvement on commandPtr handling to prevent sharing issues (das) check-in: d7d621bd0c user: hobbs tags: trunk
* exp_main_sub.c (exp_interpreter): cleaner handling of commandPtr to prevent crash. (das) check-in: 3aac82ce54 user: hobbs tags: trunk
* exp_glob.c (Exp_StringCaseMatch2): Fixed bug in the handling of glob classes, see [SF Bug 1873404]. The code tried to match the closing bracket of a class in the input because it was not properly skipped after the class was matched successfully. Additional trace output added. * configure.in: Bumped version to * configure: Regen'd, autoconf 2.59. check-in: 55b4d539f9 user: andreas_kupries tags: trunk
* exp_pty.c: Minimal ansification of function definitions to match them to their prototypes where promoted types are otherwise causing a mismatch for some compilers, like AIX in 64bit mode. * configure.in: Bumped version to * configure: Regen'd, autoconf 2.59. check-in: 3f9980272b user: andreas_kupries tags: trunk
* configure.in: Bumped version to * configure: Regen'd, autoconf 2.59. * The following set of changes was sent our way by Reinhard Max <[email protected]>. * exp_command.c: Fixed more compiler warnings, and started * exp_command.h: to ansify the code base, beginning with * exp_inter.c: the introduction of proper function prototypes. * exp_main_exp.c: * exp_pty.h: * exp_tty.c: * exp_tty.h: * exp_win.c: * expect.c: * pty_termios.c: * retoglob.c: check-in: e37bec9cc7 user: andreas_kupries tags: trunk
* configure.in: Bumped version to * configure: Regen'd, autoconf 2.59. * The following set of changes was sent our way by Reinhard Max <[email protected]>. * configure.in: Fixed checking of stty on linux, do not restrict to specific cpu's. Further try with stdin, and stdin redirected to /dev/tty when determining if stdout is read. * testsuite/configure.in: Brought up to TEA 3.5. * testsuite/aclocal.m4: New file, to import the TEA definitions. * Dbg.c: Added missed CONST in declaration and definition of 'debugger_trap'. * exp_command.c: Fixed pointer aliasing trouble with 'Tcl_DetachPids', and added the missing initialization of the command string in the 'overlay' command. * expect.c: Fixed missing initialization of 'simple_start' element of 'ecase'. * exp_inter.c: Fixed bogus use of 'slen' in 'intMatch'. The relevant string is Tcl_Unichar, not Utf. * Makefile.in: Replaced bogus INSTALL_ROOT with DESTDIR, and added missing DESTDIR references to the target for the installation of the manpages. check-in: 2c4e134aac user: andreas_kupries tags: trunk
* expect.c: Fixed refcounting error when parsing a single expect * configure.in: argument into a list of patterns and * configure: actions. Updated the version number to * Dbg.c: Added missing 'return TCL_OK' to debugger_trap. check-in: 67cf87fb01 user: andreas_kupries tags: trunk
* exp_log.c (expStdoutLogU): correct which buf is output check-in: af13f9b5a8 user: hobbs tags: trunk
(Exp_SendObjCmd): fix -- handling to expect last argument check-in: a928d6ddf1 user: hobbs tags: trunk
whitespace police check-in: 7a62024556 user: hobbs tags: trunk
(Exp_SendLogObjCmd): fix -- handling check-in: d499762dce user: hobbs tags: trunk
* exp_inter.c: Changed inclusion of tcl.h to tclInt.h to get the * expect.c: definition of TCL_REG_BOSONLY, which was moved to that header in Tcl 8.5. Ditto for expect.c, for the macro TclUtfToUniChar (was a function in 8.4). Expect now compiles again for both Tcl 8.4 and 8.5. * configure.in: Bumped version to * configure: Regenerated. check-in: d9d1562bdc user: andreas_kupries tags: trunk
* retoglob.c (EMITC): Keep the characters '^' and '$' quoted as well, we do not wish to invoke their special interpretation by the Expect glob matcher. * configure.in: Bumped version to * configure: Regenerated. check-in: 8fd850d6fe user: andreas_kupries tags: trunk
* retoglob.c: We had ExpChopNested and ExpBackslash locally ansified (prototypes) to avoid a compiler error on AIX (type promotion trouble). This now integrated into the mainline sources, conditional to AIX. check-in: 7086277753 user: andreas_kupries tags: trunk
* expect.c (Exp_TimestampObjCmd): Fixed argument processing broken by objc,objv conversion. Tried to use command name as the argument for -seconds. Also did not detect when one argument to many was specified. * configure.in: Bumped version to * configure: Regenerated. check-in: 829a7a20eb user: andreas_kupries tags: trunk
* expect.c: Circumvented problems with the C compiler by use of a temporary variable to hold the unicode pointer of a glob pattern. The computed pattern length given to Exp_StringCaseMatch was bogus. * exp_glob.c: Added tracing of the glob matcher internals (Can be enabled by define EXP_INTERNAL_TRACE_GLOB). Fixed bug in a guard condition in the optimized handling of '*'. The bad condition caused the code to miss possible matches at the beginning of the input (first char). * tests/expect.test: Added tests which check the glob matcher and RE gate keeping. * configure.in: Bumped to to separate this from the regular 5.44.1 sources. * configure: Regenerated. check-in: 9815e30fa0 user: andreas_kupries tags: trunk
* expect.c: Found bugs mismanaging input and pattern in the * exp_glob.c: updated glob matcher. We cannot check for '\0' anymore to find the end of the string, these are counted arrays now. Rewritten to use sentinel pointers. check-in: 418c1dd458 user: andreas_kupries tags: trunk
* exp_chan.c: Converted the buffering system from UTF-8 in Tcl_Obj * exp_command.h: to UTF-16 C-array, to avoid the repeated conversion * expect.c: of the input from utf-8 to utf-16. Updated the glob * exp_glob.c: matching code to use the same tricks for speed which * exp_inter.c: are used by the Tcl core. Extended the regexp * exp_log.c: matching path with a glob matcher which uses a gate * exp_log.h: keeper glob pattern to weed out most non-candidates * retoglob.c (New file): in a speedy manner. Regexp matching now has to be done only for the small number of candidates identified by the gate keeper. Overall speed improvement as glob matching is faster than regexp matching. Added code translating regular expressions into their gate keeper glob pattern. check-in: b236a54f31 user: andreas_kupries tags: trunk
* Dbg.c: Converted the lot of argc,argv based command * exp_command.c: implementations over to objc,objv. * expect.c: * exp_main_sub.c: check-in: 51926427fb user: andreas_kupries tags: trunk
* Dbg.c: Cleaned up the direct access to interp->result, * exp_command.c: replaced with the proper functions and * expect.c: Tcl_Obj's. * exp_main_exp.c: * exp_main_sub.c: * exp_main_tk.c: * exp_prog.h: * exp_trap.c: * exp_tty.c: * exp_win.c: * exp_win.h: check-in: 12ba94624a user: andreas_kupries tags: trunk
* tests/cat.test: Added proper 'package require Expect' * tests/expect.test: to the test setup code (JeffH). * tests/logfile.test: * tests/pid.test: * tests/send.test: * tests/spawn.test: * tests/stty.test: check-in: e1e81a3fc1 user: andreas_kupries tags: trunk
* exp_command.c: Reformatted overlong lines, whitespace, * expect.c: comments. Added braces to some if-constructs. * exp_inter.c: Reworked if-constructs interleaved with * exp_tty.c: #if for better formatting in emacs. check-in: 8c290788c4 user: andreas_kupries tags: trunk
* Dbg.c: Added note about unhandled cases in a switch. * exp_chan.c: Added code to suppress unhandled warning for unreachable code. * exp_command.c: Removed unused variable. * expect.c: Removed unused static function, added code to suppress unhandled warning for unreachable code. check-in: 6181af45e7 user: andreas_kupries tags: trunk
* exp_command.c: Fixed typo in comment. check-in: cad5ba9615 user: andreas_kupries tags: trunk
* Merged changes from the official version 5.44.1 of expect into the SF sources. See the details below. -------------------- Marius Schamsula <[email protected]> reported tclconfig missing, evidentally for new TEA. Lots of massaging to fix TEAification of Makefile and configure including that version numbers will now be full three part. Daniel Wong <[email protected]> noted the home page should note that Wikipedia has a very readable entry for Expect. Andre Alves <[email protected]> noted passmass needed some fixes to handle Solaris 9 passwd prompt changes. Andreas fixed several things: changes to better support TEA, fix debugger interaction with nonblocking mode, and probably other things I'm overlooking. Martin Dietze <[email protected]> noted that autoconf 2.59 is confused by C comment after undefs in expect_cf.h.in. Added additional code to unbuffer -p so that if a process earlier in the pipeline exits, unbuffer attempts to recover any remaining output from the spawned proc before unbuffer itself exits. Jeffrey Hobbs noted that once stty was called, a bg'd script would be suspended at exit. Turned out to be overaggressive code in stty that recorded what 'damage' the user might have caused when calling stty in the first place. Jens Petersen provided patch to make setpgrp configure better on some Linux systems. Added example/getpassck script to test for getpass bug. multixterm had debugging stuff leftover ("hello"). -------------------- check-in: c26f3be061 user: andreas_kupries tags: trunk