Bwidget Source Code
View Ticket
Not logged in
Bounty program for improvements to Tcl and certain Tcl packages.
Tcl 2019 Conference, Houston/TX, US, Nov 4-8
Send your abstracts to [email protected]
or submit via the online form by Sep 9.
Ticket UUID: d7ea07c40a6fa51a2719b20dd1ed2101a2bf9a12
Title: Only support Tile 0.8 and newer + spacing in themed Font Toolbar
Type: Bug Version: 1.9.10
Submitter: oehhar Created on: 2016-03-22 08:52:49
Subsystem: bwidget 1.x Assigned To: nobody
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2016-03-22 09:05:18
Resolution: Fixed Closed By: oehhar
    Closed on: 2016-03-22 09:05:18
Description:

When invoking "bwidget::theme 1", the errorInfo is filled:

% Widget::theme 1
1
% set errorInfo
invalid command name "style"
    while executing
"style default BWSlim.Toolbutton -padding 0"

The command executes in widget.tcl:

catch {style default BWSlim.Toolbutton -padding 0}
which causes this littering.

Well, the whole implementation of the command deals with tile 0.6. I suppose, we should only support tile 0.8 (including ttk namespace).

Now, about the BWSlim.Toolbutton. This is only used in font.tcl:

		ttk::checkbutton $path.$st -takefocus 0 \
		    -style BWSlim.Toolbutton \
		    -image [Bitmap::get $st] \
		    -variable SelectFont::${path}($st) \
		    -command [list SelectFont::_update $path]

Perhaps, this definition (which did not work for years now) should move to this file.

You may test its effectiveness by the following script:

Widget::theme 1
ttk::style configure BWSlim.Toolbutton -padding 0
pack [SelectFont .f -type toolbar]

If the ttk::style is removed, the original behaviour is restored. There is less space between the buttons...

I will try to attache a picture with:

  • non themed font toolbar
  • themed toolbar with the bug contained since tile 0.7 (more space)
  • themed toolbar with bug corrected

Anybody has an opinion what is best ?

Thank you, Harald

User Comments: oehhar added on 2016-03-22 09:05:18:
Anyway fixed in commit [4f9f713d30]:
   *   font toolbar button spacing 0 also when themed
   *   require Ttk or tile 0.7

Harald

Attachments: