Bwidget Source Code
View Ticket
Not logged in
Bounty program for improvements to Tcl and certain Tcl packages.
Tcl 2019 Conference, Houston/TX, US, Nov 4-8
Send your abstracts to [email protected]
or submit via the online form by Sep 9.
Ticket UUID: 3c2b8eafc6c949de9e6d0d557698f3985950e8a3
Title: Drop Widget::syncoptions
Type: Patch Version: 1.9.7
Submitter: anonymous Created on: 2014-05-14 10:09:42
Subsystem: (unused) Assigned To: nobody
Priority: 5 Medium Severity: Minor
Status: Closed Last Modified: 2014-05-21 07:50:46
Resolution: Accepted Closed By: oehhar
    Closed on: 2014-05-21 07:50:46
Description:
From: Adrián Medraño Calvo <[email protected]>

The implementation maps options in the class-specific ${class}::sync variable,
but it is not accessed at all by any other code. Probably superseded by some
other mechanism.
---
 bwidget-1.9.7/button.tcl     |  2 --
 bwidget-1.9.7/combobox.tcl   |  2 --
 bwidget-1.9.7/label.tcl      |  2 --
 bwidget-1.9.7/labelentry.tcl |  3 ---
 bwidget-1.9.7/labelframe.tcl |  2 --
 bwidget-1.9.7/widget.tcl     | 15 ---------------
 6 files changed, 26 deletions(-)

diff --git a/bwidget-1.9.7/button.tcl b/bwidget-1.9.7/button.tcl
index 5b8fc23..3d21d4a 100644
--- a/bwidget-1.9.7/button.tcl
+++ b/bwidget-1.9.7/button.tcl
@@ -42,8 +42,6 @@ namespace eval Button {
 
     DynamicHelp::include Button balloon
 
-    Widget::syncoptions Button "" :cmd {-text {} -underline {}}
-
     variable _current ""
     variable _pressed ""
 
diff --git a/bwidget-1.9.7/combobox.tcl b/bwidget-1.9.7/combobox.tcl
index 8b2cfbc..d754e06 100755
--- a/bwidget-1.9.7/combobox.tcl
+++ b/bwidget-1.9.7/combobox.tcl
@@ -61,8 +61,6 @@ namespace eval ComboBox {
 	}
     }
 
-    Widget::syncoptions ComboBox Entry .e {-text {}}
-
     ::bind BwComboBox <FocusIn> [list after idle {BWidget::refocus %W %W.e}]
     ::bind BwComboBox <Destroy> [list ComboBox::_destroy %W]
 
diff --git a/bwidget-1.9.7/label.tcl b/bwidget-1.9.7/label.tcl
index b73db1b..cf5fc0c 100644
--- a/bwidget-1.9.7/label.tcl
+++ b/bwidget-1.9.7/label.tcl
@@ -48,8 +48,6 @@ namespace eval Label {
         COLOR   {move {}}
     }
 
-    Widget::syncoptions Label "" .l {-text {} -underline {}}
-
     bind BwLabel <FocusIn> [list Label::setfocus %W]
     bind BwLabel <Destroy> [list Label::_destroy %W]
 }
diff --git a/bwidget-1.9.7/labelentry.tcl b/bwidget-1.9.7/labelentry.tcl
index f0893a4..f63599c 100644
--- a/bwidget-1.9.7/labelentry.tcl
+++ b/bwidget-1.9.7/labelentry.tcl
@@ -24,9 +24,6 @@ namespace eval LabelEntry {
 
     Widget::addmap LabelEntry "" :cmd {-background {}}
 
-    Widget::syncoptions LabelEntry Entry .e {-text {}}
-    Widget::syncoptions LabelEntry LabelFrame .labf {-label -text -underline {}}
-
     ::bind BwLabelEntry <FocusIn> [list focus %W.labf]
     ::bind BwLabelEntry <Destroy> [list LabelEntry::_destroy %W]
 }
diff --git a/bwidget-1.9.7/labelframe.tcl b/bwidget-1.9.7/labelframe.tcl
index 6f51930..3c81623 100644
--- a/bwidget-1.9.7/labelframe.tcl
+++ b/bwidget-1.9.7/labelframe.tcl
@@ -33,8 +33,6 @@ namespace eval LabelFrame {
     Widget::addmap LabelFrame "" :cmd {-background {}}
     Widget::addmap LabelFrame "" .f   {-background {} -relief {} -borderwidth {}}
 
-    Widget::syncoptions LabelFrame Label .l {-text {} -underline {}}
-
     bind BwLabelFrame <FocusIn> [list Label::setfocus %W.l]
     bind BwLabelFrame <Destroy> [list LabelFrame::_destroy %W]
 }
diff --git a/bwidget-1.9.7/widget.tcl b/bwidget-1.9.7/widget.tcl
index 348c5f9..2aee154 100755
--- a/bwidget-1.9.7/widget.tcl
+++ b/bwidget-1.9.7/widget.tcl
@@ -458,21 +458,6 @@ proc Widget::addmap { class subclass subpath options } {
 
 
 # ----------------------------------------------------------------------------
-#  Command Widget::syncoptions
-# ----------------------------------------------------------------------------
-proc Widget::syncoptions { class subclass subpath options } {
-    upvar 0 ${class}::sync classync
-
-    foreach {option realopt} $options {
-        if { ![string length $realopt] } {
-            set realopt $option
-        }
-        set classync($option) [list $subpath $subclass $realopt]
-    }
-}
-
-
-# ----------------------------------------------------------------------------
 #  Command Widget::init
 # ----------------------------------------------------------------------------
 proc Widget::init { class path options } {
-- 
1.9.2
User Comments: oehhar added on 2014-05-21 07:50:46:

Apparently correct. Committed by checkin [cc45806c6f] Thank you, Harald