D 2024-04-10T14:41:11.865
J icomment Since\sthe\stests\sfor\sthis\sticket\swere\sintegrated\sinto\sthe\sTk\stest\ssuite,\r\nI\sdidn't\shave\sa\sclose\slook\sto\sthem.\s(That's\smerely\sbecause\smy\sdrive\sto\sdo\sso\r\nis\sinversely\sproportional\sto\smy\sconfidence\sthat\syou\sdid\sthis\saccurately,\r\nFrançois.)\sWell,\sI\sdid\sthat\snow,\sand\severything\slooks\sfine\sto\sme,\sexcept\sfor\sthe\r\nfollowing\stwo\saspects\swhere\sI\shave\sa\ssmall\sdoubt/question:\r\n\r\nA.\sRegarding\sthis\sline:\r\n\r\n\s\s\s\s\s\s\s\s[https://core.tcl-lang.org/tk/file?ci=e3db006d1160463e&name=tests/event.test&ln=913]\r\n\s\s\s\s\r\n\s\s\s\sIn\smy\soriginal\stest\sscript\sthe\scode\sreads:\r\n\s\s\s\s\r\n\s\s\s\s\s\s\s\stkwait\svisibility\s.\r\n\s\s\s\s\s\s\s\supdate;\s#\sservice\sremaining\sscreen\sdrawing\sevents\s(e.g.\s<Expose>)\r\n\r\n\s\s\s\sNow\sit\sis:\r\n\r\n\s\s\s\s\s\s\s\s_pause\s200;\s#\sservice\sremaining\sscreen\sdrawing\sevents\s(e.g.\s<Expose>)\r\n\r\n\s\s\s\sa.\sWas\sthe\sremoval\sof\sthe\scall\sto\s"tkwait\svisibility"\son\spurpose?\sIt\smakes\sthat\r\n\s\s\s\s\s\s\swe\scan't\sbe\ssure\sthat\sthe\swindow\sis\svisible,\se.g.\sif\sthe\send\suser's\ssystem\r\n\s\s\s\s\s\s\sis\svery\sbusy\sprocessing\sother\sstuff\sduring\sthe\s200\sms\sthat\sthe\sTk\sprocess\r\n\s\s\s\s\s\s\sis\swaiting).\sThis\smakes\sme\suncomfortable.\r\n\s\s\s\sb.\sIf\sthe\sremoval\sof\sthe\scall\sto\s"tkwait\svisibility"\swas\son\spurpose,\sthen\r\n\s\s\s\s\s\s\sthe\scomment\sis\ssomewhat\smisleading,\sespecially\sthe\sword\s"remaining".\r\n\s\s\s\s\s\s\sWhat's\shappening\sduring\sthe\s[_pause\s200]\sis\smuch\smore\sthan\sjust\sthe\r\n\s\s\s\s\s\s\sservicing\sof\s"remaining"\sdrawing\sevents.\sA\sbetter\scomment\swould\sbe:\r\n\s\s\s\r\n\s\s\s\s\s\s\s\s\s\s_pause\s200;\s#\slet\sthe\sdrawing\sof\sthe\swindow\sto\sthe\sscreen\soccur\sto\sits\scompletion\r\n\r\n\s\s\s\s\s\s\s(or\ssomething\sequivalent).\r\n\r\nB.\sRegarding\sthe\s200\sms\sthat\s_pause\sis\swaiting:\r\n\s\s\sIt\sdidn't\sgo\sunnoticed\sthat\s200\sms\sis\sless\sthan\sthe\scurrent\svalue\sfor\sMOUSE_TIMER_INTERVAL\r\n\s\s\s(250\sms).\sThe\schoice\smakes\sthat\sthere\sis\sno\stime\sfor\sthe\ssequence\sMouseTimerProc()\s->\sTk_PointerEvent()\r\n\s\s\sto\sbe\srun\stwice.\s(This\sis\son\sMS\sWindows,\sI\sdon't\sknow\sif\sthis\salso\sholds\sfor\smacOS/aqua).\r\n\s\s\s\r\n\s\s\sWas\sthis\sconsideration\sindeed\sthe\sreason\sfor\schoosing\s200\sms?\sIf\sso,\swouldn't\sit\swise\sto\r\n\s\s\sadd\sthis\sas\san\sexplanation\ssomewhere?
J login erikleunissen
J mimetype text/x-fossil-plain
K 22349fc78a7354435595369924179e8fabafb484
U erikleunissen
Z 56182123117ad3bb6da018ac21c40708
