Overview
| Artifact ID: | 718cb197a430bf792748c6ac6bc4a4710b49ab92e1199304221950032acb4348 |
|---|---|
| Ticket: | edb4b065f49b9e51304ccdba4ee4e126ba379b0d
Crash in string compare of empty string against byte array |
| User & Date: | sebres 2024-03-28 22:12:27 |
Changes
- closedate changed to: "2460398.4253209"
- closer changed to: "sebres"
- icomment:
Huh?... The cost of tcltest::fileEncoding will be approximately 50µs per file. What by the 200 files amounts to "burdening" 10 milliseconds. As for the "asciifying" in [03cf62003a88a5f2] - it is not quite kosher. Firstly, ab\u7266 is not the same as ab牦 (first is unicode string, another is object with utf-8 bytes), what may change the test, internally. Still worse it may look by replacement for ü - \xFC, which is single-byte, and may work for windows with cp1252 as system encoding (and unix with utf-8 by fallback from ascii through cp1252), but may fail for platforms with another single-byte system encodings, not to mention the backport to Tcls where it behaves similar to 8.5 (where \xFC may be bytearray). Then maybe better something like [encoding convertfrom cp1252 \xFC]. However, if one see the costs... is the effort, difference to 8.7/9.0 (and a removal of, imho, nice feature) justified?
- login: "sebres"
- mimetype: "text/x-fossil-wiki"